Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(element): fix Radio.Group Checkbox.Group warning #3986 #4003

Merged
merged 1 commit into from
Oct 23, 2023

Conversation

lumdzeehol
Copy link
Contributor

@lumdzeehol lumdzeehol commented Oct 23, 2023

Before submitting a pull request, please make sure the following is done...

  • Ensure the pull request title and commit message follow the Commit Specific in English.
  • Fork the repo and create your branch from master or formily_next.
  • If you've added code that should be tested, add tests!
  • If you've changed APIs, update the documentation.
  • Ensure the test suite passes (npm test).
  • Make sure your code lints (npm run lint) - we've done our best to make sure these rules match our internal linting guidelines.

Please do not delete the above content


What have you changed?

Radio.Group and Checkbox.Group 由 1b809a3 的修复将change映射为undefined产生 #3986 的warning, 修复后将无效的handler映射到noop. fix #3986

@lumdzeehol
Copy link
Contributor Author

image
@janryWang 白总看看ci是否异常了

@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d8716ea) 99.55% compared to head (821b358) 99.55%.

Additional details and impacted files
@@              Coverage Diff              @@
##           formily_next    #4003   +/-   ##
=============================================
  Coverage         99.55%   99.55%           
=============================================
  Files               152      152           
  Lines              6716     6716           
  Branches           1881     1881           
=============================================
  Hits               6686     6686           
  Misses               29       29           
  Partials              1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@janryWang janryWang merged commit 39d6431 into alibaba:formily_next Oct 23, 2023
12 checks passed
@lumdzeehol lumdzeehol deleted the fix_3986 branch October 24, 2023 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report] Radio.Group、Checkbox.Group will warn on 'change' event handler
2 participants