Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kv] Support first row merge engine #240

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

luoyuxia
Copy link
Collaborator

@luoyuxia luoyuxia commented Dec 20, 2024

Purpose

Linked issue: close #133

Introduce first row merge engine for primary key table

Tests

FlussTableITCase#testFirstRowMergeEngine
FlinkTableSinkITCase#testFirstRowMergeEngine

API and Format

N/A

Documentation

I'd like to complete the document in another pr #241 since after introduce merge engine, we may need to refactor the document struture about primary key table.

Copy link
Member

@wuchong wuchong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need add validations for FlinkTableSink that first_row table doesn't supports UPDATE/DELETE and partial-update! And add tests to verify that.

@luoyuxia
Copy link
Collaborator Author

@wuchong Comments addressed...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Introduce first-row merge engine for primary key table
2 participants