[flink](lookup) project row to avoid deserialize unnecessary fields #148
+26
−49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wuchong
force-pushed
the
lookup-improve
branch
from
66c6abf to
c49e191
Compare
wuchong
requested changes
Dec 16, 2024
| // to avoid deserialize unnecessary fields | ||
| RowData flinkRow = flussRowToFlinkRowConverter.toFlinkRowData(row); | ||
| RowData flinkRow = | ||
| flussRowToFlinkRowConverter.toFlinkRowData( |
There was a problem hiding this comment.
flussRowToFlinkRowConverter works on full fields and it fails ArrayIndexOutOfBoundsException if passing projected row. Try run com.alibaba.fluss.connector.flink.source.FlinkTableSourceITCase#testLookup1PkTable.
flussRowToFlinkRowConverter should also be adapted for projection if we want it work on projected row.
There was a problem hiding this comment.
Thank you, it has been modified, and FlinkTableSourceITCase#testLookup1PkTable has been successfully run
|
I rebased the branch onto |
|
@wuchong comments addressed, PTAL, Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
project row to avoid deserialize unnecessary fields