Fix parent-child relationship #6126
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZhengguanLi
commented
Oct 1, 2024
| @@ -143,7 +143,7 @@ INSERT INTO profile_group_execution | |||
| , status, count, error_msg, error_code) | |||
| VALUES (now(), now(), ?, ?, ? | |||
| , ?, ?, ?, ?) | |||
| RETURNING (id, gmt_create, gmt_modified, group_id, mode, sql, status, count, error_msg, error_code) | |||
| RETURNING id, gmt_create, gmt_modified, group_id, mode, sql, status, count, error_msg, error_code | |||
There was a problem hiding this comment.
根据PG文档 returning 不需要括号：https://www.postgresql.org/docs/current/dml-returning.html
ZhengguanLi
commented
Oct 1, 2024
| @@ -166,7 +166,7 @@ public void test_2() throws Exception { | |||
| + "\t, ACCOUNT_ID, SUBTOTAL_DETAILBILL_ID, NVL(ACCT_HOME_COUNTY, -1)\n" | |||
| + "\t, TO_CHAR(NVL(BILLCYCLE_INURE_DATE, TO_DATE(TO_CHAR(GEN_TIME, 'yyyymm'), 'yyyymm')), 'yyyymmdd')\n" | |||
| + "\t, NVL(BILLCYCLE_MONTH, -1)\n" + "\t, NVL(Detailbill_Flag, 0)\n" | |||
| + "INTO (:b0, :b1, :b2, :b3, :b4, :b5, :b6, :b7, :b8, :b9, :b10, :b11, :b12, :b13, :b14, :b15, :b16, :b17, :b18, :b19, :b20:b21, :b22:b23, :b24:b25, :b26:b27, :b28:b29, :b30, :b31, :b32, :b33)\n" | |||
| + "INTO :b0, :b1, :b2, :b3, :b4, :b5, :b6, :b7, :b8, :b9, :b10, :b11, :b12, :b13, :b14, :b15, :b16, :b17, :b18, :b19, :b20:b21, :b22:b23, :b24:b25, :b26:b27, :b28:b29, :b30, :b31, :b32, :b33\n" | |||
There was a problem hiding this comment.
ZhengguanLi
commented
Oct 1, 2024
| x.getTarget().accept(this); | ||
| print0(" := "); | ||
| x.getValue().accept(this); | ||
| return false; |
There was a problem hiding this comment.
super.visit(x); 会使用SQLASTOutputVisitor的方法，用=来赋值，但是PG支持两种，:=更常用（https://www.postgresql.org/docs/current/plpgsql-statements.html）
|
@wenshao 可以看下这个吗 |
ZhengguanLi
force-pushed
the
fix-parent-child-relationship
branch
from
9f1c61d to
558ea7d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
SQLListExpr