[Feature] Support more message types in server #379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…port new messages
DavdGao
changed the title
rayrayraykk
reviewed
Oct 11, 2022
| @@ -225,12 +226,12 @@ def callback_funcs_for_model_para(self, message: Message): | |||
| # A fragment of the shared secret | |||
| state, content, timestamp = message.state, message.content, \ | |||
| message.timestamp | |||
| self.msg_buffer['train'][state].append(content) | |||
| self.msg_buffer[STAGE.TRAIN][state].append(content) | |||
There was a problem hiding this comment.
I'm not sure whether the 'stage' is an appropriate key name, as the key of msg_buffer should be message type (although it is not now: msg_buffer['train'] contains model, msg_buffer['eval'] contains eval results).
Maybe we should use the message type as the key of msg_buffer (like msg_buffer['model_param'] ).
What's more, are STAGE and state confusing?
rayrayraykk
reviewed
Oct 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our Target
What's in this PR
trainandevalinself.msgbuffer)STAGEinenums.pyto avoid using string directlycheck_and_move_onandcheck_bufferfucntions to support more messages.