fix: modal layout shift for none overlay scrollbar #1868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Legend-Master
requested review from
shortcuts and
francoischalifour
as code owners
|
| Name | Link |
|---|---|
| 🔨 Latest commit | 4b64ecc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current way of preventing scrolling will hide the scrollbar and causing a layout shift when using a none overlay scrollbar (default on windows)
I can only think of two ways to handle this, but they all cause a pretty small layout shift on sticky elements (1px)
But to be honest, I would prefer not to do it at all, able to scroll the things behind the searching UI is not a big problem comparison to a layout shift to me