fix sonar findings

alfio-event · Aug 30, 2024 · f3baca2 · f3baca2
1 parent 9f3eaba
commit f3baca2
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/src/main/java/alfio/manager/AccessService.java b/src/main/java/alfio/manager/AccessService.java
@@ -34,6 +34,7 @@
 import alfio.repository.user.OrganizationRepository;
 import alfio.repository.user.UserRepository;
 import alfio.repository.user.join.UserOrganizationRepository;
+import alfio.util.MiscUtils;
 import org.apache.logging.log4j.LogManager;
 import org.apache.logging.log4j.Logger;
 import org.springframework.stereotype.Service;
@@ -579,7 +580,7 @@ public void checkEventAndReservationOwnership(Principal principal, String eventN
         var eventAndOrgId = checkEventOwnership(principal, eventName);
         if (reservationIds.size() != reservationRepository.countReservationsWithEventId(reservationIds, eventAndOrgId.getId())) {
             if (log.isWarnEnabled()) {
-                log.warn("Some reservation ids {} are not in the event {}", reservationIds, removeTabsAndNewlines(eventName));
+                log.warn("Some reservation ids {} are not in the event {}", reservationIds.stream().map(MiscUtils::removeTabsAndNewlines).collect(Collectors.toSet()), removeTabsAndNewlines(eventName));
             }
             throw new AccessDeniedException();
         }

diff --git a/src/main/java/alfio/manager/PassKitManager.java b/src/main/java/alfio/manager/PassKitManager.java
@@ -260,7 +260,9 @@ public Optional<Pair<EventAndOrganizationId, Ticket>> validateToken(String event
 
         var eventOptional = eventRepository.findOptionalEventAndOrganizationIdByShortName(eventName);
         if(eventOptional.isEmpty()) {
-            log.trace("event {} not found", eventName);
+            if (log.isTraceEnabled()) {
+                log.trace("event {} not found", removeTabsAndNewlines(eventName));
+            }
             return Optional.empty();
         }