Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added notification ability fixes #9 #10

Closed
wants to merge 3 commits into from

Conversation

AdriVanHoudt
Copy link

fixes #9 according to https://developers.google.com/cloud-messaging/concept-options#notifications_and_data_messages

I added the option at the end to make it non breaking (I hope, never done Go before ^^)
Let me know if this needs any changing otherwise would it be possible to merge since we need it asap.

@AdriVanHoudt
Copy link
Author

Hate to bump this but any eta on this or comments?

cc @alexjlockwood

@0x7061
Copy link

0x7061 commented Nov 4, 2015

@AdriVanHoudt Can you add content_available and priority? See #12 - I think your PR is already more advanced.

@AdriVanHoudt
Copy link
Author

I can look into it, content_available is ios specific right?

@0x7061
Copy link

0x7061 commented Nov 4, 2015

Yes! It's needed to wake up an iOS app if a notification arrives. Thank you very much!

@AdriVanHoudt
Copy link
Author

I can only do this by end of the week btw, just a heads up ;)

@0x7061
Copy link

0x7061 commented Nov 4, 2015

That's absolutely fine :)

@pauldub
Copy link

pauldub commented May 27, 2016

Hello, it would be nice to see this being merged. It is simple enough that it should not be an issue @alexjlockwood would your like a PR with Notification being pointer or anything else? I think it would provide a better API that way.

@AdriVanHoudt
Copy link
Author

@pauldub wow completely lost track of this, will add this back on my todo list!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Send notification
5 participants