Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to use Postgres #12

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

lubieniebieski
Copy link
Contributor

hey I use postgres db a lot and I think it is generally a very popular DB for Rails usage. I've made a few additions to make it possible to install this database in an easy way by using your config and making it more general (see app_db_password variable for instance).

What do you think about it - is it something worth considering?

@aleks
Copy link
Owner

aleks commented Apr 19, 2018

I'm experiencing problems while using mysql (mysql2 adapter/gem) with the "encoding: unicode", why did you change it from utf8 to unicode?

@aleks
Copy link
Owner

aleks commented May 8, 2018

@lubieniebieski any updates on this? :)

@lubieniebieski
Copy link
Contributor Author

hi sorry, I've just become a father again and I was away from the code:)

anyway, I thought that this should be pretty much the same, but the doc says that the defaults are:
unicode for postgres and utf8 for mysql2.

However, I've checked it on my local project (postgres) and it works fine with utf8 encoding.

My suggestion is to bring back the utf8 setting and leave it there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants