chore: enabling push metrics on openshift ci (konflux-ci#830)

* enabling push metrics on openshift ci * small fix * added some more fixes * Adding me as an approver
albarbaro · Oct 23, 2023 · b0cd00a · b0cd00a
1 parent 464fa04
commit b0cd00a
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 2 deletions.
diff --git a/.github/workflows/loadtest.yaml b/.github/workflows/loadtest.yaml
@@ -40,6 +40,7 @@ jobs:
         USERS_PER_THREAD: ${{ github.event.inputs.users }}
         THREADS: ${{ github.event.inputs.threads }}
         PUSHGATEWAY_URL: ${{ secrets.PUSHGATEWAY_URL }}
+        DISABLE_METRICS: ${{ secrets.DISABLE_METRICS }}
       run: ./run-stage.sh
 
     - name: Collect results

diff --git a/OWNERS b/OWNERS
@@ -22,3 +22,4 @@ approvers:
 - jkopriva
 - Dannyb48
 - psturc
+- sawood14012
diff --git a/tests/load-tests/run-max-concurrency.sh b/tests/load-tests/run-max-concurrency.sh
@@ -23,7 +23,7 @@ load_test() {
         -l \
         -o "$output_dir" \
         -t "$threads" \
-        --disable-metrics \
+         --disable-metrics="${DISABLE_METRICS:-false}" \
         --pushgateway-url "${PUSHGATEWAY_URL:-rhtapqe.com}" \
         --enable-progress-bars="${ENABLE_PROGRESS_BARS:-false}" \
         --pipeline-skip-initial-checks="${PIPELINE_SKIP_INITIAL_CHECKS:-true}"

diff --git a/tests/load-tests/run-stage.sh b/tests/load-tests/run-stage.sh
@@ -12,6 +12,7 @@ go run loadtest.go \
     -l \
     -o "${OUTPUT_DIR:-.}" \
     -t "${THREADS:-2}" \
+    --disable-metrics="${DISABLE_METRICS:-false}" \
     --pushgateway-url "${PUSHGATEWAY_URL:-rhtapqe.com}" \
     --enable-progress-bars="${ENABLE_PROGRESS_BARS:-false}" \
     --pipeline-skip-initial-checks="${PIPELINE_SKIP_INITIAL_CHECKS:-true}"
diff --git a/tests/load-tests/run.sh b/tests/load-tests/run.sh
@@ -66,7 +66,7 @@ else
         -o "$output_dir" \
         -t "${THREADS:-1}" \
         $RANDOM_PREFIX_FLAG \
-        --disable-metrics \
+        --disable-metrics="${DISABLE_METRICS:-false}" \
         --pushgateway-url "${PUSHGATEWAY_URL:-rhtapqe.com}" \
         --enable-progress-bars="${ENABLE_PROGRESS_BARS:-false}" \
         --pipeline-skip-initial-checks="${PIPELINE_SKIP_INITIAL_CHECKS:-true}"