Skip to content

Commit

Permalink
fix(RHTAPBUGS-1051): skip the ginkgo nodes that are re-running NBE te…
Browse files Browse the repository at this point in the history
…sts (konflux-ci#991)

Problem:

* Currently, our nbe.go test suite re-runs an integration test on the
  Snapshot within an "ephemeral namespace".
* This test coverage was added as part of Integration service's re-run feature.
* However, this new addition is causing failures specifically on the CI of the
  integration-service repo.
* Why? Because Integration service uses smaller cluster pool to run its CI jobs.

Solution:

* Just to be clear, this is just what I believe is causing the problem.
* In order to confirm it, I'm confirming the related test nodes, and monitor
  the CI jobs to see if it made any difference.

Signed-off-by: Dheeraj<[email protected]>
  • Loading branch information
dheerajodha authored Jan 12, 2024
1 parent 3d53746 commit 6b62a60
Showing 1 changed file with 6 additions and 3 deletions.
9 changes: 6 additions & 3 deletions tests/integration-service/namespace-backed-environments.go
Original file line number Diff line number Diff line change
Expand Up @@ -263,21 +263,24 @@ var _ = framework.IntegrationServiceSuiteDescribe("Namespace-backed Environment
})
})

It("creates a new IntegrationTestScenario with ephemeral environment", func() {
// skipped due to RHTAPBUGS-1051
It("creates a new IntegrationTestScenario with ephemeral environment", Pending, func() {
var err error
newIntegrationTestScenario, err = f.AsKubeAdmin.IntegrationController.CreateIntegrationTestScenarioWithEnvironment(applicationName, testNamespace, gitURL, revisionForNBE, pathInRepoForNBE, userPickedEnvironment)
Expect(err).ShouldNot(HaveOccurred())
})

It("updates the Snapshot with the re-run label for the new scenario", FlakeAttempts(3), func() {
// skipped due to RHTAPBUGS-1051
It("updates the Snapshot with the re-run label for the new scenario", Pending, FlakeAttempts(3), func() {
updatedSnapshot := snapshot.DeepCopy()
err := metadata.AddLabels(updatedSnapshot, map[string]string{snapshotRerunLabel: newIntegrationTestScenario.Name})
Expect(err).ShouldNot(HaveOccurred())
Expect(f.AsKubeAdmin.IntegrationController.PatchSnapshot(snapshot, updatedSnapshot)).Should(Succeed())
Expect(metadata.GetLabelsWithPrefix(updatedSnapshot, snapshotRerunLabel)).NotTo(BeEmpty())
})

When("An snapshot is updated with a re-run label for a given scenario", func() {
// skipped due to RHTAPBUGS-1051
When("An snapshot is updated with a re-run label for a given scenario", Pending, func() {
It("checks if the re-run label was removed from the Snapshot", func() {
Eventually(func() error {
snapshot, err = f.AsKubeAdmin.IntegrationController.GetSnapshot(snapshot.Name, "", "", testNamespace)
Expand Down

0 comments on commit 6b62a60

Please sign in to comment.