Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing CONFIG_SCHEMA and service translations #673

Merged
merged 5 commits into from
Aug 27, 2023

Conversation

bdraco
Copy link
Contributor

@bdraco bdraco commented Jul 27, 2023

BREAKING CHANGE: Home Assistant Core 2023.6.0 or later is now required

fixes https://github.com/alandtse/tesla/actions/runs/5677167144/job/15385034940

Note: we can't remove from services.yaml since old version still need it

@bdraco bdraco changed the title fix: add missing CONFIG_SCHEMA fix: add missing CONFIG_SCHEMA and translations Jul 27, 2023
@bdraco bdraco changed the title fix: add missing CONFIG_SCHEMA and translations fix: add missing CONFIG_SCHEMA and service translations Jul 27, 2023
@bdraco bdraco marked this pull request as ready for review July 27, 2023 14:36
@alandtse
Copy link
Owner

Thanks for fixing this. Since this is a really recent HA release, I may hold this for a release or too.

@Olen
Copy link
Contributor

Olen commented Aug 14, 2023

The missing service names causes other PRs to fail validation, as HASSFEST requires them:
https://github.com/alandtse/tesla/actions/runs/5856579213/job/15876614220?pr=685

@alandtse alandtse merged commit c5aad96 into alandtse:dev Aug 27, 2023
5 checks passed
@alandtse
Copy link
Owner

Thanks; merged. I'll plan a release for this in the next month or so unless we see something like the beta causing issues or we have another need to release.

@bdraco bdraco deleted the hassfest branch August 27, 2023 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants