fix: reduce entity creation code #671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
followup to alandtse#670
bdraco
commented
Jul 21, 2023
| self._car = car | ||
| self._unit_system = ( |
There was a problem hiding this comment.
AFAICT this is dead code
bdraco
commented
Jul 21, 2023
| @@ -12,22 +12,14 @@ | |||
| from .const import ATTRIBUTION, DOMAIN | |||
|
|
|||
|
|
|||
| class TeslaBaseEntity(CoordinatorEntity): | |||
| class TeslaBaseEntity(CoordinatorEntity[TeslaDataUpdateCoordinator]): | |||
There was a problem hiding this comment.
CoordinatorEntity takes a type var for the coordinator
bdraco
commented
Jul 21, 2023
| car: TeslaCar, | ||
| coordinator: TeslaDataUpdateCoordinator, | ||
| ) -> None: | ||
| """Initialise the Tesla car device.""" | ||
| super().__init__(hass, coordinator) | ||
| super().__init__(coordinator) |
There was a problem hiding this comment.
CoordinatorEntity sets self.coordinator
bdraco
commented
Jul 21, 2023
| """Initialise the Tesla device.""" | ||
| super().__init__(coordinator) | ||
| self._coordinator: TeslaDataUpdateCoordinator = coordinator | ||
| self.hass = hass |
There was a problem hiding this comment.
self.hass is set by the entity platform when the entity is added to hass
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
followup to #670
I was trying to speed up the setup a bit as well, but the real cause of the slow setup when the car is asleep is zabuldon/teslajsonpy#416