-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert Config to old codes #264
base: dev
Are you sure you want to change the base?
Conversation
@@ -0,0 +1,97 @@ | |||
[assembly: System.Runtime.Versioning.TargetFrameworkAttribute(".NETFramework,Version=v4.6.1", FrameworkDisplayName=".NET Framework 4.6.1")] | |||
namespace Hocon |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should add this to .gitignore
- don't want to include the .received.txt
files. Only the .approved.txt
files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry, I got trigger happy and clicked Commit a bit too fast
@@ -0,0 +1,494 @@ | |||
[assembly: System.Runtime.Versioning.TargetFrameworkAttribute(".NETFramework,Version=v4.6.1", FrameworkDisplayName=".NET Framework 4.6.1")] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same feedback as above
@@ -29,7 +29,7 @@ namespace Hocon | |||
/// } | |||
/// </code> | |||
/// </summary> | |||
public class HoconObject : Dictionary<string, HoconField>, IHoconElement | |||
public class HoconObject : SortedDictionary<string, HoconField>, IHoconElement |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have this object implement IReadOnlyDictionary
(or equivalent) or use a SortedDictionary
internally
Revert Config API surface and behaviour to what it was back in 2018