-
-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement a global Color Picker #432
Conversation
The current implementation won't work under wayland. The proper solution would be using the xdg portals to pick the color and fallback to this in case the dbus interface is not available. See https://flatpak.github.io/xdg-desktop-portal/portal-docs.html#gdbus-method-org-freedesktop-portal-Screenshot.PickColor The XDG portals are not Flatpak specific, they are just a bunch of dbus interfaces (as a specification) that have to be implemented by the desktop environment, there are two implementation currently, kde & gtk which should cover most use cases. |
@bilelmoussaoui thanks for your quick feedback. I'll first finish up this implementation and get it working and then I'll move forward into the XDG implementation as you suggested. I'm new to vala and Linux programming so in the meantime, I'll ping you for help. |
Sure, no problem :) thanks for the contribution! let us know if we can help somehow & good luck in your journey. |
@bilelmoussaoui thanks. Do you know the name or how I can get the eyedropper icon? I Can't find any. |
The elementary icon theme doesn't currently have a symbolic color picker. Thank you so much for your contributions, you're helping us a lot! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few changes on your awesome contribution.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's a bunch of fixes and improvements.
40a43be
to
c0d819e
Compare
Summary / How this PR fixes the problem?
Implement a global Color Picker ported from this awesome little tool https://github.com/RonnyDo/ColorPicker
Steps to Test
Screenshots
Known Issues / Things To Do
This PR fixes/implements the following bugs/features: