Solved Zoom to mouse issue/request #406 #417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We can review and suggest refactors, but would be interesting to upload an screencast of what current implementation does. |
|
Thanks for the reply. I updated my text with a gif. If required I can also upload a full res video via google drive. |
Alecaddd
approved these changes
Aug 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary / How this PR fixes the problem?
It solves the issue of only zooming to the center of the view. Now you can zoom to and from mouse position.
Known Issues / Things To Do
There might be an easier way to solve this but this is what I was able to come up with. Also this is my first commit to any project at all so please keep that in mind when giving me feedback :)
This PR fixes/implements the following bugs/features: