-
-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Saving and loading akira through serialization #209
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12508ba
to
1f54ced
Compare
First functional format:
|
@AUNaseef please keep in mind this is a tentative design (mostly a PoC that we can discard early), but can you check if you can save/load your draws with this branch? I would love to load any of your draws and take a look. (Specially for the group feature) |
|
dfa843e
to
b70676e
Compare
|
4f62f09
to
b3c8db8
Compare
b3c8db8
to
4b14f03
Compare
|
65338fd
to
cfeb982
Compare
26bf57e
to
c72e1ae
Compare
deb6b65
to
f950c95
Compare
f950c95
to
6ff494b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary / How this PR fixes the problem?
Use existing serialization:
to save and load canvas contents.
Steps to Test
This is just a PoC so it only saves first item from canvas and loads it as a rectangle.
Example file (you can generate other saving your canvas):
file.akira
Screenshots
Known Issues / Things To Do
This PR fixes/implements the following bugs/features:
Relates to #90. A svg format would be preferred anyway.