treat warnings as errors

akgulebubekir · Oct 5, 2024 · 9576d8a · 9576d8a
1 parent 9a166e4
commit 9576d8a
Show file tree

Hide file tree

Showing 8 changed files with 14 additions and 0 deletions.
diff --git a/Directory.Build.props b/Directory.Build.props
@@ -11,6 +11,7 @@
 	  <WarningLevel>9999</WarningLevel>
     <AnalysisLevel>latest-all</AnalysisLevel>
     <EnableNETAnalyzers>true</EnableNETAnalyzers>
+    <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
     <EnforceCodeStyleInBuild>true</EnforceCodeStyleInBuild>
     <GenerateDocumentationFile>true</GenerateDocumentationFile>
     <CheckForOverflowUnderflow>true</CheckForOverflowUnderflow>

diff --git a/Maui.DataGrid.Sample/App.xaml.cs b/Maui.DataGrid.Sample/App.xaml.cs
@@ -1,5 +1,7 @@
 namespace Maui.DataGrid.Sample;
 
+#pragma warning disable CA1724
+
 /// <summary>
 /// Codebehind for the App.
 /// </summary>

diff --git a/Maui.DataGrid.Sample/Converters/StreakToColorConverter.cs b/Maui.DataGrid.Sample/Converters/StreakToColorConverter.cs
@@ -1,8 +1,10 @@
 namespace Maui.DataGrid.Sample.Converters;
 
+using System.Diagnostics.CodeAnalysis;
 using System.Globalization;
 using Maui.DataGrid.Sample.Models;
 
+[SuppressMessage("Microsoft.Performance", "CA1812:AvoidUninstantiatedInternalClasses", Justification = "Instantiated via XAML")]
 internal sealed class StreakToColorConverter : IValueConverter
 {
     public object Convert(object? value, Type targetType, object? parameter, CultureInfo culture)

diff --git a/Maui.DataGrid/Collections/ObservableRangeCollection.cs b/Maui.DataGrid/Collections/ObservableRangeCollection.cs
@@ -15,11 +15,13 @@ namespace Maui.DataGrid.Collections;
 using System.Collections.ObjectModel;
 using System.Collections.Specialized;
 using System.ComponentModel;
+using System.Diagnostics.CodeAnalysis;
 
 /// <summary>
 /// Represents a dynamic data collection that provides notifications when items get added, removed, or when the whole list is refreshed.
 /// </summary>
 /// <typeparam name="T">The object type of elements in the collection.</typeparam>
+[SuppressMessage("Microsoft.Performance", "CA1812:AvoidUninstantiatedInternalClasses", Justification = "Instantiated via collection expression")]
 internal sealed class ObservableRangeCollection<T> : ObservableCollection<T>
 {
     /// <summary>

diff --git a/Maui.DataGrid/DataGrid.xaml.cs b/Maui.DataGrid/DataGrid.xaml.cs
@@ -15,6 +15,8 @@ namespace Maui.DataGrid;
 using Microsoft.Maui.Controls.Shapes;
 using Font = Microsoft.Maui.Font;
 
+#pragma warning disable CA1724
+
 /// <summary>
 /// DataGrid component for .NET MAUI.
 /// </summary>

diff --git a/Maui.DataGrid/DataGridHeaderRow.cs b/Maui.DataGrid/DataGridHeaderRow.cs
@@ -1,8 +1,10 @@
 namespace Maui.DataGrid;
 
+using System.Diagnostics.CodeAnalysis;
 using Maui.DataGrid.Extensions;
 using Microsoft.Maui.Controls;
 
+[SuppressMessage("Microsoft.Performance", "CA1812:AvoidUninstantiatedInternalClasses", Justification = "Instantiated via XAML")]
 internal sealed class DataGridHeaderRow : Grid
 {
     #region Bindable Properties

diff --git a/Maui.DataGrid/DataGridRow.cs b/Maui.DataGrid/DataGridRow.cs
@@ -1,8 +1,10 @@
 namespace Maui.DataGrid;
 
+using System.Diagnostics.CodeAnalysis;
 using Maui.DataGrid.Extensions;
 using Microsoft.Maui.Controls;
 
+[SuppressMessage("Microsoft.Performance", "CA1812:AvoidUninstantiatedInternalClasses", Justification = "Instantiated via XAML")]
 internal sealed class DataGridRow : Grid
 {
     #region Bindable Properties

diff --git a/Maui.DataGrid/Maui.DataGrid.csproj b/Maui.DataGrid/Maui.DataGrid.csproj
@@ -40,6 +40,7 @@
       <PackagePath>\</PackagePath>
     </None>
   </ItemGroup>
+
   <ItemGroup>
     <PackageReference Include="Microsoft.Maui.Controls" Version="$(MauiVersion)">
       <PrivateAssets>all</PrivateAssets>