Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Proposal: Support arrays of objects to be merged in the "with" property #27

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

simonmeusel
Copy link

See #15
Fixes #12

I've implemented a simple wrapper function for json merge patch to allow arrays.

@coveralls
Copy link

coveralls commented Jul 14, 2018

Coverage Status

Coverage remained the same at 100.0% when pulling 3fd5918 on simonmeusel:merge-arrays into d8c8c07 on epoberezkin:master.

@epoberezkin
Copy link
Member

@simonmeusel thanks, I will review over the weekend.

@lakim
Copy link

lakim commented Jan 28, 2019

I would love to see this merged.

It is very cumbersome to merge multiple schemas for now.
Here is my use case:

{
  "$merge": {
    "source": {
      "type": "object",
      "properties": {},
      "additionalProperties": false
    },
    "with": [
      {
        "$ref": "definitions/color.json#/definitions/color"
      },
      {
        "$ref": "definitions/font.json#/definitions/font"
      }
    ]
  }
}

Any help needed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants