Fix duration time to consider playback rate #1845
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think this makes sense as a default. It could be an option though |
vicente-higino
force-pushed
the
playbackrate-bar-fix
branch
from
aac73da
to
e5472eb
Compare
|
I don't think this makes sense at all unless you correct youtube's current and end times to also align with the time without segments - in which case it would be better suited for a plugin/userscript to parse instead for uniformity across all durations. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To test this pull request, follow the instructions in the wiki.
The duration of the video with skips now uses the playback rate to adjust the time.
Ex: 0:13 / 10:50 (9:16) @ 1x speed => 0:13 / 10:50 (4:38) @ 2x speed