-
Notifications
You must be signed in to change notification settings - Fork 718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Add missing tickValues
prop type
#1855
base: master
Are you sure you want to change the base?
fix: Add missing tickValues
prop type
#1855
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, an F1 app sending PRs during FP2. Needs a small change and we should be good to land this.
a87da03
to
90039a9
Compare
7ac4a6f
to
8721baa
Compare
Okay, so I've found that the Currently though, I'm struggling to use the package locally, using |
This adds two field types, fields already available in `<BaseGrid>`, to the `CommonGridTProps` type.
8721baa
to
61edd41
Compare
Any updates so far? @f1multiviewer Referring to the cd /packages/visx-demo
yarn
yarn dev Because i'm new to contributing this repo, i'll try once in then elaborate it to you later. UpdatesStruggling on building the module. 🥹 |
@f1multiviewer export type SharedAxisProps<Scale extends AxisScale> = CommonProps<Scale> & {
// ...
/** An array of values that determine the number and values of the ticks. Falls back to `scale.ticks()` or `.domain()`. */
tickValues?: ScaleInput<Scale>[];
// ...
}; How're your thoughts? |
🐛 Bug Fix
Fixes an issue where the
tickValues
property wasn't properly being typed, even though it works when being passed.Related: #376