-
Notifications
You must be signed in to change notification settings - Fork 688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
css and html bug fixes and style updates #548
Conversation
✅ Build knowledge-repo 1.0.772 completed (commit aa859b2265 by @bulam) |
✅ Build knowledge-repo 1.0.774 completed (commit 6ebd96baa4 by @bulam) |
✅ Build knowledge-repo 1.0.776 completed (commit 5207802d2b by @bulam) |
✅ Build knowledge-repo 1.0.781 completed (commit 5cec1af21e by @bulam) |
✅ Build knowledge-repo 1.0.783 completed (commit 038b107674 by @bulam) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A bunch of comments, mostly CSS related. Thanks for the design refresh! I'm going to send this over to Ken our designer to take a look as well
@etr2460 Thanks for all the comments and great suggestions. All of them make sense. I'll implement in the next few commits. |
✅ Build knowledge-repo 1.0.827 completed (commit d7f93182bf by @bulam) |
✅ Build knowledge-repo 1.0.829 completed (commit 80dded53b4 by @bulam) |
✅ Build knowledge-repo 1.0.831 completed (commit a0ee137153 by @bulam) |
❌ Build knowledge-repo 1.0.834 failed (commit c804f39216 by @bulam) |
✅ Build knowledge-repo 1.0.835 completed (commit 3c9ec906d2 by @bulam) |
✅ Build knowledge-repo 1.0.839 completed (commit 7e7740c711 by @bulam) |
❌ Build knowledge-repo 1.0.851 failed (commit 470eb9253d by @bulam) |
✅ Build knowledge-repo 1.0.853 completed (commit 0a251609f2 by @bulam) |
@etr2460 I implemented the suggested changes and implemented a few more changes. |
✅ Build knowledge-repo 1.0.869 completed (commit defc8b28d5 by @bulam) |
✅ Build knowledge-repo 1.0.871 completed (commit 58e37721c2 by @bulam) |
✅ Build knowledge-repo 1.0.873 completed (commit d3c3a1c418 by @bulam) |
✅ Build knowledge-repo 1.0.875 completed (commit 293589663c by @bulam) |
✅ Build knowledge-repo 1.0.877 completed (commit 5818bd28a0 by @bulam) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a few more comments
I noticed this too but is this just an issue in the debug server? The production instance seems to work... |
✅ Build knowledge-repo 1.0.879 completed (commit 4b423bcbe3 by @bulam) |
✅ Build knowledge-repo 1.0.881 completed (commit afd7d6868f by @bulam) |
Chatted with Naoya and found the comment feature in the post review flow is not working in prod either |
Was able to make the styling work without using the important. Does this look good for merging? @etr2460 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay here, this lgtm!
Description of changeset:
CSS & HTML bug fixes & updates:
Copy updates in the UI to clarify functionalities and guide best practices
Updated the “Create a Post” page to describe in more detail the options to add new posts
Added placeholder text for some fields in the add a post form (post path, post image thumbnail) to guide best practices or to guide usage
Renamed the Web Proxy field to “Linked Post URL” for clarity
Changed the “Write a Post!” button to “Add a Post!” reflecting the fact that you can add linked posts as well
Changed the “Web Proxy” to “Linked Post” to make this option clearer.
Also updated the screenshots in the readme to show the updated UI and copy
Added more screenshots to the readme
Test Plan: