Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

css and html bug fixes and style updates #548

Merged
merged 32 commits into from
Jun 4, 2020
Merged

css and html bug fixes and style updates #548

merged 32 commits into from
Jun 4, 2020

Conversation

bulam
Copy link
Collaborator

@bulam bulam commented May 26, 2020

Description of changeset:
CSS & HTML bug fixes & updates:

Copy updates in the UI to clarify functionalities and guide best practices

  • Updated the “Create a Post” page to describe in more detail the options to add new posts

  • Added placeholder text for some fields in the add a post form (post path, post image thumbnail) to guide best practices or to guide usage

  • Renamed the Web Proxy field to “Linked Post URL” for clarity

  • Changed the “Write a Post!” button to “Add a Post!” reflecting the fact that you can add linked posts as well

  • Changed the “Web Proxy” to “Linked Post” to make this option clearer.

  • Also updated the screenshots in the readme to show the updated UI and copy

  • Added more screenshots to the readme

Test Plan:

  • I tested the CSS and HTML fixes and updates in Chrome, Firefox and Safari in both desktop and mobile web views.

@AppVeyorBot
Copy link

@AppVeyorBot
Copy link

@bulam bulam requested a review from etr2460 May 26, 2020 19:48
@AppVeyorBot
Copy link

@AppVeyorBot
Copy link

@AppVeyorBot
Copy link

Copy link
Collaborator

@etr2460 etr2460 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bunch of comments, mostly CSS related. Thanks for the design refresh! I'm going to send this over to Ken our designer to take a look as well

knowledge_repo/app/static/css/pages/base.css Outdated Show resolved Hide resolved
knowledge_repo/app/static/css/pages/base.css Outdated Show resolved Hide resolved
knowledge_repo/app/static/css/pages/base.css Outdated Show resolved Hide resolved
knowledge_repo/app/static/css/pages/base.css Outdated Show resolved Hide resolved
knowledge_repo/app/static/css/pages/base.css Outdated Show resolved Hide resolved
knowledge_repo/app/static/css/pages/index-feed.css Outdated Show resolved Hide resolved
knowledge_repo/app/templates/auth-login-form.html Outdated Show resolved Hide resolved
knowledge_repo/app/templates/base.html Outdated Show resolved Hide resolved
knowledge_repo/app/templates/create-knowledge.html Outdated Show resolved Hide resolved
@naoyak naoyak mentioned this pull request May 27, 2020
@bulam
Copy link
Collaborator Author

bulam commented May 27, 2020

@etr2460 Thanks for all the comments and great suggestions. All of them make sense. I'll implement in the next few commits.

@AppVeyorBot
Copy link

@AppVeyorBot
Copy link

@AppVeyorBot
Copy link

@AppVeyorBot
Copy link

Build knowledge-repo 1.0.834 failed (commit c804f39216 by @bulam)

@AppVeyorBot
Copy link

@AppVeyorBot
Copy link

@AppVeyorBot
Copy link

Build knowledge-repo 1.0.851 failed (commit 470eb9253d by @bulam)

@AppVeyorBot
Copy link

@bulam
Copy link
Collaborator Author

bulam commented May 28, 2020

@etr2460 I implemented the suggested changes and implemented a few more changes.

@AppVeyorBot
Copy link

@AppVeyorBot
Copy link

@AppVeyorBot
Copy link

@AppVeyorBot
Copy link

@AppVeyorBot
Copy link

@bulam
Copy link
Collaborator Author

bulam commented Jun 1, 2020

@etr2460 I chatted with Ken and incorporated his suggestions into the design.

I also found the commenting feature in the webpost submission form is not working, so I disabled the feature for now and filed an issue here #559

Copy link
Collaborator

@etr2460 etr2460 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few more comments

knowledge_repo/app/static/css/pages/base.css Outdated Show resolved Hide resolved
knowledge_repo/app/static/css/pages/base.css Outdated Show resolved Hide resolved
knowledge_repo/app/static/css/pages/base.css Outdated Show resolved Hide resolved
knowledge_repo/app/static/css/pages/base.css Outdated Show resolved Hide resolved
knowledge_repo/app/static/css/pages/index-feed.css Outdated Show resolved Hide resolved
knowledge_repo/app/templates/post_editor_base.html Outdated Show resolved Hide resolved
@naoyak
Copy link
Collaborator

naoyak commented Jun 1, 2020

I also found the commenting feature in the webpost submission form is not working, so I disabled the feature for now and filed an issue here #559

I noticed this too but is this just an issue in the debug server? The production instance seems to work...

@AppVeyorBot
Copy link

@AppVeyorBot
Copy link

@bulam
Copy link
Collaborator Author

bulam commented Jun 1, 2020

I also found the commenting feature in the webpost submission form is not working, so I disabled the feature for now and filed an issue here #559

I noticed this too but is this just an issue in the debug server? The production instance seems to work...

Chatted with Naoya and found the comment feature in the post review flow is not working in prod either

@bulam
Copy link
Collaborator Author

bulam commented Jun 2, 2020

Was able to make the styling work without using the important. Does this look good for merging? @etr2460

Copy link
Collaborator

@etr2460 etr2460 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay here, this lgtm!

@bulam bulam merged commit 5d9674f into master Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants