Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: Updated ProblemKind to version 2 #2

Merged
merged 2 commits into from
Oct 27, 2023
Merged

Conversation

Framba-Luca
Copy link
Contributor

No description provided.

@Framba-Luca
Copy link
Contributor Author

Hi @speckdavid , this PR updates the ProblemKind to the version 2. It is added in this PR in the UP.

I added both INT_* and REAL_* in actions costs and oversubscription gains. If only integers are supported you can remove the REAL_* or just tell me to remove them.

@speckdavid
Copy link
Collaborator

Hi,

Thanks for the PR!

Symk currently only supports natural numbers (including 0) in the action cost (similar to Fast Downward). Is there a special case for this? If not, only having INT_NUMBERS_IN_ACTIONS_COST is the best fit.

For the oversubscription gains/utilites, we support positive and negative integers (this is mainly a technical thing and we have not implemented real number support yet). So I think only INT_NUMBERS_IN_OVERSUBSCRIPTION is appropriate here.

Would it be possible to remove the supported_kind.set_actions_cost_kind("REAL_NUMBERS_IN_ACTIONS_COST") and supported_kind.set_oversubscription_kind("REAL_NUMBERS_IN_OVERSUBSCRIPTION") as you suggested?

Out of curiosity, is this backwards compatible with older versions of the UP?

@speckdavid speckdavid self-assigned this Oct 26, 2023
@Framba-Luca
Copy link
Contributor Author

Thanks for clarifing; for now I removed the REAL_*; for the oversubscription we can re-add it when it will be supported.

Yes, this is (modulo bugs) fully compatible with the previous versions of the UP.

For the costs >= 0 I asked what we should expect; for now there are no hard constraints of it being positive so it might be a small issue to fix.

@speckdavid speckdavid merged commit 226dbbc into master Oct 27, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants