Use cffi 1.17.0rc1 to test Python 3.13 support #8432
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8432 +/- ##
=======================================
Coverage 97.64% 97.64%
=======================================
Files 107 107
Lines 33067 33067
Branches 3885 3885
=======================================
Hits 32288 32288
Misses 562 562
Partials 217 217
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
edgarrmondragon
force-pushed
the
cffi-prerelease
branch
from
35efd42
to
c20043f
Compare
.github/workflows/ci-cd.yml
Outdated
| @@ -189,7 +189,7 @@ jobs: | |||
| pip-ci-${{ runner.os }}-${{ matrix.pyver }}-${{ matrix.no-extensions }}- | |||
| - name: Update pip, wheel, setuptools, build, twine | |||
| run: | | |||
| python -m pip install -U pip wheel setuptools build twine | |||
| python -m pip install -U pip wheel setuptools build twine cffi==0.17.0rc1 | |||
There was a problem hiding this comment.
This seems redundant as the following step would do the same.
There was a problem hiding this comment.
Yeah, but pip (I think) has a dependency on cffi via cryptography so this step was failing on 3.13
There was a problem hiding this comment.
Pip vendors all its deps so this would do nothing. Besides, all pip's deps are pure-python.
edgarrmondragon
force-pushed
the
cffi-prerelease
branch
from
c20043f
to
8e18b32
Compare
edgarrmondragon
changed the title
edgarrmondragon
force-pushed
the
cffi-prerelease
branch
from
8e18b32
to
79277fb
Compare
|
It seems pycares is also causing issues |
|
Looks like uvloop is also failing to install currently. I suspect there's a good chance cffi will have made a stable release by the time that's sorted, so maybe not worth putting these changes in temporarily. |
edgarrmondragon
force-pushed
the
cffi-prerelease
branch
from
79277fb
to
9909716
Compare
edgarrmondragon
force-pushed
the
cffi-prerelease
branch
from
9909716
to
7fdc432
Compare
|
Looks like cffi 1.17.0 is now out |
|
I guess we close this then, as Dependabot will update it. Just waiting on uvloop now.. |
What do these changes do?
cffito support testing with Python 3.13Are there changes in behavior for the user?
Is it a substantial burden for the maintainers to support this?
Related issue number
Checklist
CONTRIBUTORS.txtCHANGES/foldername it
<issue_or_pr_num>.<type>.rst(e.g.588.bugfix.rst)if you don't have an issue number, change it to the pull request
number after creating the PR
.bugfix: A bug fix for something the maintainers deemed animproper undesired behavior that got corrected to match
pre-agreed expectations.
.feature: A new behavior, public APIs. That sort of stuff..deprecation: A declaration of future API removals and breakingchanges in behavior.
.breaking: When something public is removed in a breaking way.Could be deprecated in an earlier release.
.doc: Notable updates to the documentation structure or buildprocess.
.packaging: Notes for downstreams about unobvious side effectsand tooling. Changes in the test invocation considerations and
runtime assumptions.
.contrib: Stuff that affects the contributor experience. e.g.Running tests, building the docs, setting up the development
environment.
.misc: Changes that are hard to assign to any of the abovecategories.
Make sure to use full sentences with correct case and punctuation,
for example:
Use the past tense or the present tense a non-imperative mood,
referring to what's changed compared to the last released version
of this project.