Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

another fix for #294 #299

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

another fix for #294 #299

wants to merge 1 commit into from

Conversation

alex-eri
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Jun 19, 2018

Codecov Report

Merging #299 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #299   +/-   ##
=======================================
  Coverage   97.08%   97.08%           
=======================================
  Files           4        4           
  Lines         206      206           
  Branches       25       25           
=======================================
  Hits          200      200           
  Misses          4        4           
  Partials        2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa10335...8ba8a94. Read the comment docs.

@asvetlov
Copy link
Member

Did you hear about unittesting?

@alex-eri
Copy link
Contributor Author

@asvetlov All checks have passed.

I know about tests, but nothing to test here. Trivial fix.

@asvetlov
Copy link
Member

The "trivial" fix adds a new argument though.
This argument requires a new test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants