feat: support generic inputs for controllers #153
Merged
+93
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bpapaspyros
changed the title
|
@domire8 this contains the changes from generic outputs, we should perhaps target that branch and then merge both inputs and outputs to the staging branch. Let me know if that works for you. Otherwise we finish the review on outputs, I rebase this and then merge to the staging branch |
|
Let's change the base branch here |
domire8
changed the base branch from
feat/generic_pubsub_dev
to
feat/generic_controller_outputs
domire8
reviewed
Oct 3, 2024
source/modulo_controllers/include/modulo_controllers/BaseControllerInterface.hpp
Show resolved
Hide resolved
source/modulo_controllers/include/modulo_controllers/BaseControllerInterface.hpp
Outdated
Show resolved
Hide resolved
domire8
reviewed
Oct 3, 2024
source/modulo_controllers/include/modulo_controllers/BaseControllerInterface.hpp
Outdated
Show resolved
Hide resolved
source/modulo_controllers/include/modulo_controllers/BaseControllerInterface.hpp
Outdated
Show resolved
Hide resolved
source/modulo_controllers/include/modulo_controllers/BaseControllerInterface.hpp
Outdated
Show resolved
Hide resolved
domire8
approved these changes
Oct 4, 2024
source/modulo_controllers/include/modulo_controllers/BaseControllerInterface.hpp
Outdated
Show resolved
Hide resolved
bpapaspyros
merged commit 5e55e9c
into
feat/generic_controller_outputs
3 of 4 checks passed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR solves the issue by implementing compile-time logic to allow for custom types.
Review guidelines
Estimated Time of Review: 10 minutes
Checklist before merging: