feat: expose generic inputs and outputs to components #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bpapaspyros
changed the title
2 tasks
bpapaspyros
force-pushed
the
feat/expose_generic_outputs
branch
from
e9226c0
to
5aaea1e
Compare
1 task
domire8
reviewed
Oct 2, 2024
source/modulo_components/include/modulo_components/Component.hpp
Outdated
Show resolved
Hide resolved
source/modulo_components/include/modulo_components/LifecycleComponent.hpp
Outdated
Show resolved
Hide resolved
domire8
approved these changes
Oct 2, 2024
bpapaspyros
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After adding support for generic publishers in #141 and subscribers in #144 , the goal of this PR is to introduce the appropriate changes that expose these generic tyeps to our
ComponentandLifecycleComponentclass.This PR solves the issue by updating
Component,LifecycleComponent, andComponentInterfacewith compile-time branching logic based on message and data types.Review guidelines
Estimated Time of Review: 15 minutes
Checklist before merging:
Optional: link related issues
Related issues
Blocked by:
Blocks: