Define CAN interrupt pins #1266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agherzan
requested changes
Jan 23, 2024
There was a problem hiding this comment.
Thanks! This looks good content-wise but it lacks adhering to the guidelines in https://meta-raspberrypi.readthedocs.io/en/latest/contributing.html. Could you have a short check on it and refresh this?
Current configuration hard-code the values of the CAN interrupt pins. This setting allows to change them. The default values are the same as before. Signed-off-by: Damiano Ferrari <[email protected]>
Signed-off-by: Damiano Ferrari <[email protected]>
|
Thank you @agherzan. I hope that now it is ok |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1264
- What I did
The users can now define CAN interrupt pins that are different from the hard-coded one.
- How I did it
I defined two more CAN variables that let users configure the CAN interrupt pins depending by the module that they used (or by their custom boards). It is similar to CAN_OSCILLATOR. I also added these variables to the documentation
Once this is merged I will cherry-pick this commit to Kirkstone (because I need this change)