Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#5364 Bugfix : Sound : processSound callback saved and used with loaded + mustPlay #5365

Merged
merged 4 commits into from
Oct 23, 2023
Merged

#5364 Bugfix : Sound : processSound callback saved and used with loaded + mustPlay #5365

merged 4 commits into from
Oct 23, 2023

Commits on Oct 18, 2023

  1. aframevr#5364 Bugfix : The processSound callback given to playSound()… 

    … before the sound was loaded will be called when loaded and not ignored anymore.
    @JonathannJacobs
    JonathannJacobs committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    bf3e196 View commit details
    Browse the repository at this point in the history

  2. aframevr#5364 : Sound : Added API for reaching THREE.Audio.loopStart(… 

    …) and loopEnd()
    @JonathannJacobs
    JonathannJacobs committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    f91140a View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2023

  1. aframevr#5364 : Sound : Automatically set the loop end to the end of … 

    …the sound if a loop start was specified without an end
    @JonathannJacobs
    JonathannJacobs committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    61a5455 View commit details
    Browse the repository at this point in the history

  2. aframevr#5364 : Sound : Code review changes applied.

    @JonathannJacobs
    JonathannJacobs committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    6d48043 View commit details
    Browse the repository at this point in the history