-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AYS-224 | Emergency Evacuation Application Update #341
Merged
agitrubard
merged 28 commits into
main
from
feature/AYS-224/emergency-evacuation-update-feature
Jul 17, 2024
Merged
AYS-224 | Emergency Evacuation Application Update #341
agitrubard
merged 28 commits into
main
from
feature/AYS-224/emergency-evacuation-update-feature
Jul 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d/endpoint created.
…uationApplicationService.java -> update method created and implemented.
… map method, add mapping for institution.
…onEntity to institution.
…necessary comment.
Pr şu an testler ve javadoc'lar bakımından eksik olduğundan dolayı bu pr'ı ready olmayacak şekilde güncelleyebilir miyiz? |
…ded to use within request builder
…or Update method has been added
…ts for Update method has been added
…ency-evacuation-update-feature
… Has Been Refactored
… Has Been Covered with Unit Tests
…efactored and Endpoint Has Been Covered with Controller Tests
…int Has Been Covered with Controller Test
…turnSuccessResponse` Method Has Been Renamed as `givenValidIdAndValidUpdateRequest_whenApplicationUpdated_thenReturnSuccessResponse`
…Covered with Controller Tests in Update Endpoint
…ed with End to End Test
agitrubard
requested changes
Jul 15, 2024
...va/org/ays/emergency_application/service/impl/EmergencyEvacuationApplicationServiceImpl.java
Outdated
Show resolved
Hide resolved
…ava has been created
…s used instead of EmergencyEvacuationApplicationRequestToDomainMapper
agitrubard
requested changes
Jul 16, 2024
...ency_application/model/mapper/EmergencyEvacuationApplicationUpdateRequestToDomainMapper.java
Outdated
Show resolved
Hide resolved
agitrubard
previously approved these changes
Jul 17, 2024
agitrubard
approved these changes
Jul 17, 2024
egehanasal
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Before submitting your pull request, ensure the following:
Title and Branch Naming Conventions:
standard: Pull Request Naming Conventions.
the Branch Naming Conventions.
Local Testing:
Code Quality:
Documentation:
Testing:
Reviewers and Assignees:
Labels and Associations: