Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AYS-224 | Emergency Evacuation Application Update #341

Merged
merged 28 commits into from
Jul 17, 2024

Conversation

moaydogdu
Copy link
Contributor

@moaydogdu moaydogdu commented Jul 9, 2024

Checklist

Before submitting your pull request, ensure the following:

  • Title and Branch Naming Conventions:

  • Local Testing:

    • I have tested my changes locally on Postman, and they are working as expected.
  • Code Quality:

    • The code is formatted according to the project's coding guidelines and style.
    • The code has been reviewed to ensure its quality.
    • The code does not contain any issues flagged by SonarLint.
  • Documentation:

    • Necessary documentation has been added or existing documentation has been updated, specifically detailing changes made in Postman.
  • Testing:

    • Relevant unit tests have been written and included.
    • Relevant integration tests have been written and included.
  • Reviewers and Assignees:

    • Default reviewers have been assigned to this pull request.
    • Assignees have been added if necessary.
  • Labels and Associations:

    • No specific actions are required in the Labels and Associations section for this pull request.

@egehanasal
Copy link
Contributor

Pr şu an testler ve javadoc'lar bakımından eksik olduğundan dolayı bu pr'ı ready olmayacak şekilde güncelleyebilir miyiz?

@cengzayhn cengzayhn marked this pull request as draft July 11, 2024 12:31
@cengzayhn cengzayhn self-assigned this Jul 11, 2024
agitrubard and others added 12 commits July 14, 2024 18:18
…efactored and Endpoint Has Been Covered with Controller Tests
…turnSuccessResponse` Method Has Been Renamed as `givenValidIdAndValidUpdateRequest_whenApplicationUpdated_thenReturnSuccessResponse`
…Covered with Controller Tests in Update Endpoint
@cengzayhn cengzayhn marked this pull request as ready for review July 14, 2024 17:11
@agitrubard agitrubard self-assigned this Jul 14, 2024
agitrubard
agitrubard previously approved these changes Jul 17, 2024
@agitrubard agitrubard merged commit f0e0170 into main Jul 17, 2024
1 check passed
@agitrubard agitrubard deleted the feature/AYS-224/emergency-evacuation-update-feature branch July 17, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants