Skip to content
This repository has been archived by the owner on Oct 13, 2022. It is now read-only.

#59 bulk-update #81

Open
wants to merge 46 commits into
base: develop
Choose a base branch
from
Open

#59 bulk-update #81

wants to merge 46 commits into from

Conversation

Takeno-hito
Copy link
Member

@Takeno-hito Takeno-hito commented Nov 11, 2021 •
edited
Loading

resolve: #59

@Takeno-hito
feat: verified column in activity log
152eb8a
@Takeno-hito
test: activityLog verified column
bcc093d
@Takeno-hito
feat: bulkupdate controller post
8ad873e
@Takeno-hito
feat: request validation
5443d4d
@Takeno-hito
refactor: checkRequest method
6b6947f
@Takeno-hito
fix: abort if timestamp attribute is not timestamp
5afb4c1
@Takeno-hito
refactor: checkRequest -> handleRequest
cf8c003
@Takeno-hito
feat: reservation_id validation
56850dc
@Takeno-hito
refactor: use Carbon
45866fd
@Takeno-hito
fix: abort if timestamp is future
fe9e96b
@Takeno-hito
refactor: use request::isJson, request::input
27698ad
@Takeno-hito
style: use $data['key']
0979ba0
@Takeno-hito
refactor: handleRequest return response object
37e520a
@Takeno-hito
refactor: use Userdata (instead of $request) in handleScan argument
d4e3e02
@Takeno-hito
refactor: rename handleScan to processEntry
fa49ece
@Takeno-hito
feat: drop_guest_foreign_key_in_activity_log migration
ce17abf
@Takeno-hito
fix: correct reservation key exists check
964c788
@Takeno-hito
feat: bulk check-in
9b4be8a
@Takeno-hito
feat: bulk check-out
5445433
@Takeno-hito
feat: Guest update location method
4f4f449
@Takeno-hito
feat: bulk enter
902ec28
@Takeno-hito
feat: bulk exit
c151fb2
@Takeno-hito
feat: bulk register-spare
cb3c252
@Takeno-hito Takeno-hito added the enhancement New feature or request label Nov 11, 2021
@Takeno-hito Takeno-hito self-assigned this Nov 11, 2021
ibuki2003
ibuki2003 suggested changes Nov 11, 2021
View reviewed changes
Copy link
Member

@ibuki2003 ibuki2003 left a comment •
edited by Takeno-hito
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 例外処理
  • log
  • is_appliedの扱いが早速あやふやになってる(こないだの議論聞いてた？)
  • 末尾カンマ

database/migrations/2021_11_10_013237_add_log_verified_column.php Outdated Show resolved Hide resolved
routes/web.php Show resolved Hide resolved
app/Http/Controllers/BulkUpdateController.php Outdated Show resolved Hide resolved
app/Models/Guest.php Outdated Show resolved Hide resolved
app/Models/Guest.php Outdated Show resolved Hide resolved
ibuki2003
ibuki2003 suggested changes Nov 11, 2021
View reviewed changes
Copy link
Member

@ibuki2003 ibuki2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ねむい

app/Http/Controllers/BulkUpdateController.php Outdated Show resolved Hide resolved
app/Http/Controllers/BulkUpdateController.php Show resolved Hide resolved
app/Http/Controllers/BulkUpdateController.php Show resolved Hide resolved
app/Models/Guest.php Outdated Show resolved Hide resolved
@Takeno-hito Takeno-hito mentioned this pull request Nov 11, 2021
Open
@Takeno-hito Takeno-hito marked this pull request as ready for review November 11, 2021 11:33
@Takeno-hito
Copy link
Member Author

  • is_ok どこがあやふやか教えて欲しい
  • 末尾 ,、linterが設定してくれてると思ってたけど、、

@Takeno-hito
Copy link
Member Author

全部眺めたけど , 入ってないとこなくね

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@su8ru su8ru Awaiting requested review from su8ru

@ibuki2003 ibuki2003 Awaiting requested review from ibuki2003

At least 1 approving review is required to merge this pull request.

Assignees

@Takeno-hito Takeno-hito

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

#287 Bulk-Update の追加
2 participants
@Takeno-hito @ibuki2003