Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement: Use uv instead of pip during ci tests #440

Merged
merged 1 commit into from
May 21, 2024

Conversation

AtomHare
Copy link
Contributor

This PR makes the Hyperion repo use uv during ci tests. uv is a replacement for pip written in rust.
Ideally, ci tests should now be quicker ! No expected breakage from this PR since we don't use special pip functionalities (see https://astral.sh/blog/uv)

We'll use the official setup python gh action with uv when it will be merged or implemented (see actions/setup-python#818).

@AtomHare AtomHare added enhancement New feature or request github_actions Pull requests that update GitHub Actions code labels May 16, 2024
Copy link

codecov bot commented May 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.74%. Comparing base (20149f3) to head (da92413).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #440   +/-   ##
=======================================
  Coverage   82.74%   82.74%           
=======================================
  Files          97       97           
  Lines        6078     6078           
=======================================
  Hits         5029     5029           
  Misses       1049     1049           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@armanddidierjean armanddidierjean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow 😍

.github/workflows/lintandformat.yml Outdated Show resolved Hide resolved
.github/workflows/test.yml Outdated Show resolved Hide resolved
.github/workflows/lintandformat.yml Outdated Show resolved Hide resolved
.github/workflows/test.yml Outdated Show resolved Hide resolved
While also using uv cache if the dependencies are the same in requirements and requirements-dev

fix: Auto-detection of python version

fix: Missed comment

Fix suggestions
@julien4215 julien4215 merged commit 0175965 into main May 21, 2024
7 checks passed
@julien4215 julien4215 deleted the gh-actions-enhancement branch May 21, 2024 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants