Annotations for dependecies #413
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julien4215
added
enhancement
julien4215
force-pushed
the
annotated-syntax
branch
from
b960c44
to
c7697a8
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #413 +/- ##
==========================================
+ Coverage 80.35% 80.40% +0.05%
==========================================
Files 85 85
Lines 5797 5792 -5
==========================================
- Hits 4658 4657 -1
+ Misses 1139 1135 -4 ☔ View full report in Codecov by Sentry. |
armanddidierjean
removed
the
dependencies
| @@ -274,9 +269,12 @@ def is_user_a_member( | |||
| return user | |||
|
|
|||
|
|
|||
| MemberUser = Annotated[models_core.CoreUser, Depends(is_user_a_member)] | |||
There was a problem hiding this comment.
Shouldn't it be UserMember to stay consistant with the rest of the code ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://fastapi.tiangolo.com/release-notes/#0950