Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

png2src: add ability to handle any width #713

Merged
merged 3 commits into from
Jul 22, 2024

Conversation

lukki15
Copy link
Contributor

@lukki15 lukki15 commented Apr 28, 2024

solves #497

tested on these images, for 1bpp and 2bpp:

7x7 pixels:
smiley_1bpp_7x7
smiley_2bpp_7x7

8x8 pixels:
smiley_1bpp_8x8
smiley_2bpp_8x8

Copy link
Owner

@aduros aduros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me with some quick manual testing. Thanks!

It would be good to someday have some automated tests here as the math is a bit tricky.

cli/lib/png2src.js Outdated Show resolved Hide resolved
@aduros aduros merged commit 953c7d4 into aduros:main Jul 22, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants