MWPW-161871 [MEP] useblockcode action fails if page is on milo site #3161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e used by the library (#3047) * create mepxlg branch * update library * require full hostname match * update reference for unit test * switch to use config instead of domain list and stub response in unit test * update fetch to 2 * updating another fetch to 2 * restore normalizePath to use preview domains on preview links * preload segment list json * use getFederatedUrl instead * import at top so we don't have to make normalizePath async * MWPW-148129 [MILO][MEP][GNAV] Able to use select by url feature with federated link (#3064) * add federated link function to registerInBlockActions * add to unit test * add unit test coverage
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## mephrefplaceholders #3161 +/- ##
====================================================
Coverage 96.36% 96.36%
====================================================
Files 245 245
Lines 56439 56439
====================================================
Hits 54386 54386
Misses 2053 2053 ☔ View full report in Codecov by Sentry. |
chrischrischris
approved these changes
Nov 8, 2024
vgoodric
approved these changes
Nov 8, 2024
vgoodric
added
verified
milo-pr-merge bot
pushed a commit
that referenced
this pull request
Nov 12, 2024
…updating href (#3142) * MWPW-161590 [MEP] Update placeholders before updating href * unit test updates * MWPW-161871 [MEP] useblockcode action fails if page is on milo site (#3161) * stash * ready to publish * interact call coming back but timing out * working on a fast connection * clean up ifs * working with promise * use camel case on let variable * unit tests * update unit tests * MWPW-149504 [MILO][MEP] Move entitlements object to the same JSON file used by the library (#3047) * create mepxlg branch * update library * require full hostname match * update reference for unit test * switch to use config instead of domain list and stub response in unit test * update fetch to 2 * updating another fetch to 2 * restore normalizePath to use preview domains on preview links * preload segment list json * use getFederatedUrl instead * import at top so we don't have to make normalizePath async * MWPW-148129 [MILO][MEP][GNAV] Able to use select by url feature with federated link (#3064) * add federated link function to registerInBlockActions * add to unit test * add unit test coverage * initial commit * Fix useblock code issue --------- Co-authored-by: vgoodric <[email protected]> Co-authored-by: Vivian A Goodrich <[email protected]> * MWPW-161606 [MEP] Modify within modals with MEP (#3171) initial commit publish Co-authored-by: viloria <[email protected]> * add conditionals --------- Co-authored-by: Mark Perry <[email protected]> Co-authored-by: viloria <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the MEP action, useBlockCode, works if the page is on a consumer site, but not if it is on the milo sub-site.
This PR updates getBlockProps in personalization.js to fall back to config.codeRoot when config.miloLibs is undefined.
Resolves: MWPW-MWPW-161871
QA steps: check that the marquee in the After link of the Test URLS below is replace by the following text: 'Marquee code was replaced MEP and the content was overwritten.'
Also, I'm including the following consumer repo links for verification that useBlockCode still works properly in consumer repos:
https://main--bacom--adobecom.hlx.page/drafts/markp/useblock?milolibs=mepblockcodemilo
https://main--dc--adobecom.hlx.page/drafts/markp/mepblockcodemilo?milolibs=mepblockcodemilo
https://main--homepage--adobecom.hlx.page/homepage/drafts/mepdev/2024/mepblockcodemilo?milolibs=mepblockcodemilo
https://main--cc--adobecom.hlx.page/drafts/mepdev/fragments/2024/q4/mepblockcodemilo/basepage
Test URLs: