Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding client's search component class to exclude from getting it clicked on keydown #3145

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

bandana147
Copy link
Contributor

  • Added client's search component class to exclude from getting it clicked on keydown

Resolves: MWPW-161627

Test URLs:

Qa: https://www.stage.adobe.com/home?navbranch=search-fix

@bandana147 bandana147 added needs-verification PR requires E2E testing by a reviewer high priority Why is this a high priority? Blocker? Critical? Dependency? labels Nov 6, 2024
Copy link
Contributor

aem-code-sync bot commented Nov 6, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link
Contributor

aem-code-sync bot commented Nov 6, 2024

Page Scores Audits Google
📱 /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link

codecov bot commented Nov 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.35%. Comparing base (38504d5) to head (6a58a62).
Report is 7 commits behind head on stage.

Additional details and impacted files
@@           Coverage Diff           @@
##            stage    #3145   +/-   ##
=======================================
  Coverage   96.35%   96.35%           
=======================================
  Files         245      245           
  Lines       56370    56370           
=======================================
  Hits        54316    54316           
  Misses       2054     2054           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@spadmasa
Copy link

spadmasa commented Nov 6, 2024

Validation done on the PR in below url
https://www.stage.adobe.com/home?navbranch=search-fix
{94754169-30E7-4F7F-A8C2-466AF2F62DED}
validation done in different browsers and device details in https://jira.corp.adobe.com/browse/MWPW-161627

@spadmasa spadmasa added verified PR has been E2E tested by a reviewer Ready for Stage and removed needs-verification PR requires E2E testing by a reviewer labels Nov 6, 2024
@milo-pr-merge milo-pr-merge bot merged commit f12d8ec into stage Nov 6, 2024
36 checks passed
@milo-pr-merge milo-pr-merge bot deleted the search-fix branch November 6, 2024 10:13
@milo-pr-merge milo-pr-merge bot mentioned this pull request Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
high priority Why is this a high priority? Blocker? Critical? Dependency? Ready for Stage verified PR has been E2E tested by a reviewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants