-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MWPW-155315 Set Marketo POI #3129
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stage #3129 +/- ##
==========================================
+ Coverage 96.35% 98.77% +2.42%
==========================================
Files 245 70 -175
Lines 56316 8430 -47886
==========================================
- Hits 54261 8327 -45934
+ Misses 2055 103 -1952 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just one suggestion
libs/blocks/marketo/marketo.js
Outdated
if (productOfInterest) { | ||
formData[PROGRAM_POI] = productOfInterest; | ||
formData[POI_FILTER] = 'hidden'; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: early return instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good
This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR. |
Resolves: MWPW-155315
Test URLs:
BACOM URLs: