Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MWPW-155315 Set Marketo POI #3129

Closed
wants to merge 2 commits into from
Closed

MWPW-155315 Set Marketo POI #3129

wants to merge 2 commits into from

Conversation

@Brandon32 Brandon32 added run-nala Run Nala Test Automation against PR @marketo Run Marketo Block Tests labels Nov 1, 2024
Copy link
Contributor

aem-code-sync bot commented Nov 1, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link
Contributor

aem-code-sync bot commented Nov 1, 2024

Copy link

codecov bot commented Nov 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.77%. Comparing base (d809cd5) to head (0dc296c).
Report is 30 commits behind head on stage.

Additional details and impacted files
@@            Coverage Diff             @@
##            stage    #3129      +/-   ##
==========================================
+ Coverage   96.35%   98.77%   +2.42%     
==========================================
  Files         245       70     -175     
  Lines       56316     8430   -47886     
==========================================
- Hits        54261     8327   -45934     
+ Misses       2055      103    -1952     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@meganthecoder meganthecoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one suggestion

Comment on lines 156 to 159
if (productOfInterest) {
formData[PROGRAM_POI] = productOfInterest;
formData[POI_FILTER] = 'hidden';
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: early return instead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good

Copy link
Contributor

github-actions bot commented Nov 2, 2024

This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR.

@Brandon32 Brandon32 closed this Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@marketo Run Marketo Block Tests run-nala Run Nala Test Automation against PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants