MWPW-158077 rollout new Timeline block #2926
Open
+140
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stage #2926 +/- ##
==========================================
+ Coverage 96.24% 96.25% +0.01%
==========================================
Files 236 237 +1
Lines 54278 54432 +154
==========================================
+ Hits 52241 52395 +154
Misses 2037 2037 ☔ View full report in Codecov by Sentry. |
vgoodric
reviewed
Sep 19, 2024
| .dialog-modal .timeline { | ||
| padding: 0 var(--spacing-xl) var(--spacing-xl) var(--spacing-xl); | ||
| } | ||
| } | ||
|
|
||
| @media screen and (min-width: 1200px) { | ||
| @media screen and (min-width:1120px) { |
There was a problem hiding this comment.
curious what the reason was to switch to 1120
There was a problem hiding this comment.
this was part of a request for 10 col max width and mirrors what I see in the codebase for .section.grid-width-10
vgoodric
approved these changes
Sep 19, 2024
|
Reminder to set the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds new block: timeline
Resolves: MWPW-158077
QA test link: https://main--cc--adobecom.hlx.page/drafts/markp/timeline?milolibs=timelinerollout
Test URLs: