MWPW-155984 - Brick list showing null value in link label

[ryanmparrish]

Added a conditional check in a shared function decorateIconStack() that was causing this.

(This brick list authoring was triggering some shared link checking logic that wasn't properly verifying for null values)

Resolves: MWPW-155984

Test URLs:

• Before: https://main--milo--adobecom.hlx.page/drafts/rparrish/masonry/brick-list?martech=off
• After: https://rparrish-brick-lists--milo--adobecom.hlx.page/drafts/rparrish/masonry/brick-list?martech=off

Live URLs:

• Before: https://main--dc--adobecom.hlx.page/drafts/ntran/brick-null-bug?martech=off
• After: https://main--dc--adobecom.hlx.page/drafts/ntran/brick-null-bug?milolibs=rparrish-brick-lists&martech=off

Regression: blocks that use this function (aside, brick)

• aside Before: https://main--milo--adobecom.hlx.page/docs/library/kitchen-sink/aside?martech=off
• aside After: https://rparrish-brick-lists--milo--adobecom.hlx.page/docs/library/kitchen-sink/aside?martech=off
• brick Before: https://main--milo--adobecom.hlx.page/docs/library/kitchen-sink/brick?martech=off
• brick After: https://rparrish-brick-lists--milo--adobecom.hlx.page/docs/library/kitchen-sink/brick?martech=off

[aem-code-sync]

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

• Re-run PSI checks
• Re-sync branch

Commits

• 66d094b ✅ (latest)

[aem-code-sync]

	Page	Scores	Audits	Google
📱	/docs/library/kitchen-sink/aside?martech=off
🖥️	/docs/library/kitchen-sink/aside?martech=off
📱	/docs/library/kitchen-sink/brick?martech=off
🖥️	/docs/library/kitchen-sink/brick?martech=off
📱	/drafts/rparrish/masonry/brick-list?martech=off
🖥️	/drafts/rparrish/masonry/brick-list?martech=off

[codecov]

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 96.24%. Comparing base (adf2a9c) to head (66d094b).
Report is 9 commits behind head on stage.

Files with missing lines	Patch %	Lines
libs/utils/decorate.js	40.00%	3 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##            stage    #2921   +/-   ##
=======================================
  Coverage   96.23%   96.24%           
=======================================
  Files         236      236           
  Lines       54254    54257    +3     
=======================================
+ Hits        52212    52217    +5     
+ Misses       2042     2040    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[JasonHowellSlavin]

LGTM. Does feel like a unit test should have caught this.

[github-actions]

This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR.

[overmyheadandbody]

Also had a look over asides with lists, things look good, thanks for looking into this!

[mokimo]

LGTM. Does feel like a unit test should have caught this.

Agree, would be good to see if we can add one as part of this PR a follow-up

[NadiiaSokolova]

Verified. Ready for Stage.
Testing details https://jira.corp.adobe.com/browse/MWPW-155984

[milo-pr-merge]

Skipped merging 2921: MWPW-155984 - Brick list showing null value in link label due to failing checks