MWPW-157147: Dynamic Nav Status Button #2920
Conversation
… QA in understanding which nav is active
JasonHowellSlavin
requested review from
salonijain3,
bandana147,
sharmrj,
nishantka,
Deva309,
sonawanesnehal3 and
a team
as code owners
JasonHowellSlavin
added
run-nala
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## stage #2920 +/- ##
==========================================
- Coverage 96.24% 96.24% -0.01%
==========================================
Files 236 237 +1
Lines 54254 54391 +137
==========================================
+ Hits 52217 52346 +129
- Misses 2037 2045 +8 ☔ View full report in Codecov by Sentry. |
| @@ -1126,6 +1126,10 @@ export async function loadDeferred(area, blocks, config) { | |||
| import('../features/personalization/preview.js') | |||
| .then(({ default: decoratePreviewMode }) => decoratePreviewMode()); | |||
| } | |||
| if (config?.dynamicNavKey) { | |||
| const { default: loadDNStatus } = await import('../features/dynamic-navigation/status.js'); | |||
There was a problem hiding this comment.
Looks like this file will load on prod even though you're not showing the status there. Would be good to have an env check here
There was a problem hiding this comment.
Was following mep's pattern and have the env check in the main function, but can move it here.
| transition-duration: 0.2s; | ||
| } | ||
|
|
||
| .dns-badge.dns-open::after{ |
There was a problem hiding this comment.
| .dns-badge.dns-open::after{ | |
| .dns-badge.dns-open::after { |
| rotate: 180deg; | ||
| } | ||
|
|
||
| .dynamic-nav-status p{ |
There was a problem hiding this comment.
| .dynamic-nav-status p{ | |
| .dynamic-nav-status p { |
| width: 100%; | ||
| } | ||
|
|
||
| .dynamic-nav-status .disable-values caption{ |
There was a problem hiding this comment.
| .dynamic-nav-status .disable-values caption{ | |
| .dynamic-nav-status .disable-values caption { |
| border-bottom: 1px solid white; | ||
| } | ||
|
|
||
| .dynamic-nav-status .disable-values{ |
There was a problem hiding this comment.
| .dynamic-nav-status .disable-values{ | |
| .dynamic-nav-status .disable-values { |
|
This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR. |
Context:
The milo repo does not have the dynamicNavKey in the config, so the first two links will not show the feature.
Resolves: MWPW-157147
Test URLs:
Bacom