Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MWPW-157147: Dynamic Nav Status #2918

Closed

Conversation

JasonHowellSlavin
Copy link
Contributor

  • Adds a status button to appear in the nav to inform content QA and QA whether or not the Dynamic Nav is active and to provide additional information about Dynamic Nav and it's settings.
  • The experience is set for tablet and up, since the core user is QA.

Context:
The milo repo does not have the dynamicNavKey in the config, so the first two links will not show the feature. The second set of links, I am using the milo branch "dynamic-nav-preview" due to code bus issues, there is parity between both branches.

Resolves: MWPW-157147

Test URLs:

Bacom

Copy link
Contributor

aem-code-sync bot commented Sep 19, 2024

Copy link

codecov bot commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.24%. Comparing base (99a0fd7) to head (666aed4).
Report is 45 commits behind head on stage.

Additional details and impacted files
@@            Coverage Diff             @@
##            stage    #2918      +/-   ##
==========================================
+ Coverage   96.08%   96.24%   +0.16%     
==========================================
  Files         215      237      +22     
  Lines       53946    54391     +445     
==========================================
+ Hits        51835    52351     +516     
+ Misses       2111     2040      -71     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JasonHowellSlavin JasonHowellSlavin added run-nala Run Nala Test Automation against PR needs-verification PR requires E2E testing by a reviewer labels Sep 19, 2024
@JasonHowellSlavin
Copy link
Contributor Author

Closing due to commits, will open another.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-verification PR requires E2E testing by a reviewer run-nala Run Nala Test Automation against PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant