Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MWPW-157450: Localization Enhancements for quiz-entry block needed #2917

Merged
merged 2 commits into from
Sep 25, 2024

Conversation

Copy link
Contributor

aem-code-sync bot commented Sep 19, 2024

Page Scores Audits Google
📱 /drafts/quiz/quiz-entry/?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /drafts/quiz/quiz-entry/?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@JackySun9 JackySun9 added bug Something isn't working uar labels Sep 19, 2024
Copy link

codecov bot commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.27%. Comparing base (c5e352f) to head (3894efe).
Report is 15 commits behind head on stage.

Additional details and impacted files
@@            Coverage Diff             @@
##            stage    #2917      +/-   ##
==========================================
- Coverage   98.21%   96.27%   -1.94%     
==========================================
  Files          64      238     +174     
  Lines        7848    54515   +46667     
==========================================
+ Hits         7708    52485   +44777     
- Misses        140     2030    +1890     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@sukamat sukamat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JackySun9 Some tests are failing...

@JackySun9 JackySun9 added the needs-verification PR requires E2E testing by a reviewer label Sep 19, 2024
@JackySun9
Copy link
Contributor Author

@JackySun9 Some tests are failing...

@skumar09 will fix it

Copy link
Contributor

This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR.

@JackySun9 JackySun9 added run-nala-on-caas bug Something isn't working and removed bug Something isn't working uar needs-verification PR requires E2E testing by a reviewer run-nala-on-caas labels Sep 23, 2024
@JackySun9 JackySun9 added verified PR has been E2E tested by a reviewer Ready for Stage labels Sep 24, 2024
@milo-pr-merge
Copy link
Contributor

milo-pr-merge bot commented Sep 24, 2024

Skipped merging 2917: MWPW-157450: Localization Enhancements for quiz-entry block needed due to failing checks

@mokimo mokimo merged commit 5d8d656 into adobecom:stage Sep 25, 2024
36 of 38 checks passed
@mokimo mokimo mentioned this pull request Sep 25, 2024
denlight pushed a commit that referenced this pull request Sep 25, 2024
…2917)

Revert "MWPW-156749: Fix video CLS " (#2899) (#2900)

Revert "MWPW-156749: Fix video CLS  (#2849)"

This reverts commit d4134c8.
denlight pushed a commit that referenced this pull request Sep 25, 2024
…2917)

Revert "MWPW-156749: Fix video CLS " (#2899) (#2900)

Revert "MWPW-156749: Fix video CLS  (#2849)"

This reverts commit d4134c8.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Ready for Stage run-nala-on-caas verified PR has been E2E tested by a reviewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants