Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to configure children for unav's help component #2911

Open
wants to merge 2 commits into
base: stage
Choose a base branch
from

Conversation

bandana147
Copy link
Contributor

  • Add option to configure children for unav's help component
  • Universal nav has option to add custom children - link
  • Need to add support for that from milo gnav.

Resolves: MWPW-158737

Test URLs:

Qa: https://adobecom.github.io/nav-consumer/navigation.html?authoringpath=/federal/dev&env=stage&navbranch=unav-configurable

@bandana147 bandana147 added the needs-verification PR requires E2E testing by a reviewer label Sep 19, 2024
Copy link
Contributor

aem-code-sync bot commented Sep 19, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link
Contributor

aem-code-sync bot commented Sep 19, 2024

Page Scores Audits Google
📱 /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link

codecov bot commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.24%. Comparing base (c80cf18) to head (1b38578).
Report is 1 commits behind head on stage.

Additional details and impacted files
@@           Coverage Diff           @@
##            stage    #2911   +/-   ##
=======================================
  Coverage   96.24%   96.24%           
=======================================
  Files         236      236           
  Lines       54253    54255    +2     
=======================================
+ Hits        52216    52218    +2     
  Misses       2037     2037           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@prativas22 prativas22 assigned prativas22 and unassigned prativas22 Sep 19, 2024
@prativas22
Copy link

@prativas22 prativas22 added verified PR has been E2E tested by a reviewer Ready for Stage and removed needs-verification PR requires E2E testing by a reviewer labels Sep 19, 2024
@milo-pr-merge
Copy link
Contributor

milo-pr-merge bot commented Sep 19, 2024

Skipped 2911: "Add option to configure children for unav's help component" due to file "libs/blocks/global-navigation/global-navigation.js" overlap. Merging will be attempted in the next batch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready for Stage verified PR has been E2E tested by a reviewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants