-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to configure children for unav's help component #2911
base: stage
Are you sure you want to change the base?
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stage #2911 +/- ##
=======================================
Coverage 96.24% 96.24%
=======================================
Files 236 236
Lines 54253 54255 +2
=======================================
+ Hits 52216 52218 +2
Misses 2037 2037 ☔ View full report in Codecov by Sentry. |
Verified the PR Note: Adobe Home will take care of the Help components upon click, which are currently not functional. Without sign in With sign in Notification check: |
Skipped 2911: "Add option to configure children for unav's help component" due to file "libs/blocks/global-navigation/global-navigation.js" overlap. Merging will be attempted in the next batch |
Resolves: MWPW-158737
Test URLs:
Qa: https://adobecom.github.io/nav-consumer/navigation.html?authoringpath=/federal/dev&env=stage&navbranch=unav-configurable