Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MWPW-158480 Exclude defaults from caas links #2907

Merged
merged 2 commits into from
Sep 25, 2024

Conversation

meganthecoder
Copy link
Contributor

@meganthecoder meganthecoder commented Sep 18, 2024

  • Removes defaults from state before creating caas config link
  • Reduces caas link length by 25-30% for the longest links

Related to discussion: https://github.com/orgs/adobecom/discussions/2876

Resolves: MWPW-158480

Test URLs:
Page with old/new links

Copy link
Contributor

aem-code-sync bot commented Sep 18, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link
Contributor

aem-code-sync bot commented Sep 18, 2024

Page Scores Audits Google
📱 /drafts/methomas/caas-link-v3?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /drafts/methomas/caas-link-v3?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link

codecov bot commented Sep 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.24%. Comparing base (840e037) to head (a18abed).
Report is 37 commits behind head on stage.

Additional details and impacted files
@@            Coverage Diff             @@
##            stage    #2907      +/-   ##
==========================================
+ Coverage   96.23%   96.24%   +0.01%     
==========================================
  Files         237      236       -1     
  Lines       54242    54244       +2     
==========================================
+ Hits        52198    52207       +9     
+ Misses       2044     2037       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@meganthecoder
Copy link
Contributor Author

Failing unit test is unrelated, for the bulk publish tool

@meganthecoder meganthecoder added run-nala Run Nala Test Automation against PR caas-configurator CaaS Configurator CaaS CaaS related code @caas labels Sep 18, 2024
@meganthecoder
Copy link
Contributor Author

Copy link
Contributor

This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR.

Copy link
Contributor

Reminder to set the Ready for Stage label - to queue this to get merged to stage & production.

@Dli3 Dli3 added verified PR has been E2E tested by a reviewer Ready for Stage labels Sep 24, 2024
@milo-pr-merge milo-pr-merge bot merged commit 3d1726d into stage Sep 25, 2024
38 checks passed
@milo-pr-merge milo-pr-merge bot deleted the methomas/caas-link-len branch September 25, 2024 08:33
@milo-pr-merge milo-pr-merge bot mentioned this pull request Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CaaS CaaS related code @caas caas-configurator CaaS Configurator Ready for Stage run-nala Run Nala Test Automation against PR verified PR has been E2E tested by a reviewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants