MWPW-152411 raw md doc for web components & events #2903
+1,359
−1,122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- will need some jsdocs flesh in comments for both components & events, - can be linked from or to with card specific doc pages
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stage #2903 +/- ##
==========================================
- Coverage 96.24% 96.24% -0.01%
==========================================
Files 236 236
Lines 54253 54264 +11
==========================================
+ Hits 52216 52224 +8
- Misses 2037 2040 +3 ☔ View full report in Codecov by Sentry. |
yesil
reviewed
Sep 19, 2024
| * HTML Checkout Link Anchor element, extends anchor | ||
| * | ||
| * @element a[data-wcs-osi] | ||
| * @fires merch:click |
There was a problem hiding this comment.
it doesn't fire merch:click though.
There was a problem hiding this comment.
right, this was a test, i'll remove it
There was a problem hiding this comment.
(click doc will come with click event pr)
| /** | ||
| * HTML Price Web Component, extends span | ||
| * | ||
| * @element span[data-wcs-osi] |
yesil
reviewed
Sep 19, 2024
| /** @type {Commerce.Price.PlaceholderConstructor} */ | ||
| /** | ||
| * HTML Price Web Component, extends span. | ||
| * special member _onceSettled_ promise that either resolves or fail with web commerce information. |
There was a problem hiding this comment.
it always resolves actually. when it fails, it will add placeholder-failed class to the element.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test URLs: