Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MWPW-158462 [MEP] any-marquee-section simplified selector #2884

Merged
merged 6 commits into from
Sep 17, 2024
Merged

MWPW-158462 [MEP] any-marquee-section simplified selector #2884

merged 6 commits into from
Sep 17, 2024

Conversation

vgoodric
Copy link
Contributor

@vgoodric vgoodric commented Sep 16, 2024 •
edited
Loading

@vgoodric vgoodric requested a review from a team as a code owner September 16, 2024 16:15
@aem-code-sync AEM Code Sync
Copy link
Contributor

aem-code-sync bot commented Sep 16, 2024 •
edited
Loading

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@vgoodric vgoodric requested review from Ruchika4 and a team September 16, 2024 16:15
@aem-code-sync AEM Code Sync
Copy link
Contributor

aem-code-sync bot commented Sep 16, 2024 •
edited
Loading

Page Scores Audits Google
📱 /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@codecov Codecov
Copy link

codecov bot commented Sep 16, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.24%. Comparing base (840e037) to head (faa1ea2).
Report is 4 commits behind head on stage.

Additional details and impacted files 
@@            Coverage Diff             @@
##            stage    #2884      +/-   ##
==========================================
+ Coverage   96.23%   96.24%   +0.01%     
==========================================
  Files         237      237              
  Lines       54242    54240       -2     
==========================================
+ Hits        52198    52202       +4     
+ Misses       2044     2038       -6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vgoodric vgoodric added verified PR has been E2E tested by a reviewer Ready for Stage labels Sep 16, 2024
@vgoodric
MWPW-158475 [MEP] classes that end in a number are modified when they…
4b1f438 
… should not be (#2886)

* unit test update

* MWPW-158475 [MEP] classes that end in a number are modified when they should not be

* unit test repair

* unit test repair
@vgoodric
MWPW-157686 [MEP] Cannot spoof an experience that exists in manifest …
faa1ea2 
…but not in Target (#2887)

* working so far

* lint update

* update something merging stage did not
@milo-pr-merge milo-pr-merge bot merged commit 8da3683 into stage Sep 17, 2024
14 checks passed
@milo-pr-merge milo-pr-merge bot deleted the mepanymarqueesection branch September 17, 2024 09:15
@milo-pr-merge milo-pr-merge bot mentioned this pull request Sep 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ruchika4 Ruchika4 Ruchika4 approved these changes

@ivanvatadobe ivanvatadobe ivanvatadobe approved these changes

Assignees
No one assigned
Labels
Ready for Stage verified PR has been E2E tested by a reviewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vgoodric @Ruchika4 @ivanvatadobe