MWPW-158071: Optimize LCP loading times #2882
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## stage #2882 +/- ##
==========================================
- Coverage 96.24% 96.21% -0.03%
==========================================
Files 238 237 -1
Lines 54316 54261 -55
==========================================
- Hits 52277 52209 -68
- Misses 2039 2052 +13 ☔ View full report in Codecov by Sentry. |
mokimo
force-pushed
the
marquee-perf-improvements
branch
from
ef018cb
to
a555eda
Compare
|
Rightfully failing nala tests, I'll have to look at them and change the loading order for the placeholders a bit... |
|
This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR. |
|
I'll open a follow up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It's relatively hard to track performance beforehand, however we observed a +500MS (13%) gain on CC pages speeding up loading placeholders. We've also seen good success with preloading as noted in this discussion
Decorate.js
This PR initially introduced the idea of preloading
decorate.jsfor a performance gain, but introduced too much flexibility. The idea of preloadingdecorate.jsfor specifically the two common (hero-)marquees blocks is valuable and worth the added 3 lines of code, as neither is likely to change anytime soon.Impressions
This should provide good benefits on a wide arrange of blocks, consumers and pages by optimizing the load order and chains, however we will want to observe the CRUM/RUM/CRUX data after merging the changes in this PR
Resolves: MWPW-158071
Test URLs: