Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MWPW-158053: CCD Slice Card [Merch card] #2878

Merged
merged 26 commits into from
Sep 25, 2024
Merged

MWPW-158053: CCD Slice Card [Merch card] #2878

merged 26 commits into from
Sep 25, 2024

Commits on Aug 30, 2024

  1. MWPW-156612 fragment merch-card variant layouts 

    - move from merch-card.js code each layout code related to a given variant under variants/<variant> class
- move from global.css.js css related to a given variant under variants/<variant>.css.js
- move from merch-card.css.js wc css related to a given variant under variants/<variant>.variantStyle
- uses variants/variants as an index to get related class from related variant, and wc style too,
- uses variants/VariantLayout, superclass of all variants, to insert css if card is used, and hold common code
    @npeltier
    npeltier committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    03778dd View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2024

  1. MWPW-156612 changing title selector 

    to something independent of the layout (not initialized when used at first in collections)
    @npeltier
    npeltier committed Aug 31, 2024
    Configuration menu
    Copy the full SHA
    7ead9eb View commit details
    Browse the repository at this point in the history

Commits on Sep 1, 2024

  1. MWPW-156612 forking style insertion

    @npeltier
    npeltier committed Sep 1, 2024
    Configuration menu
    Copy the full SHA
    a8ab869 View commit details
    Browse the repository at this point in the history

  2. MWPW-156612 styles fixes

    @npeltier
    npeltier committed Sep 1, 2024
    Configuration menu
    Copy the full SHA
    b9580d5 View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2024

  1. MWPW-156612 review comments

    @npeltier
    npeltier committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    6df1623 View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2024

  1. Merge branch 'stage' of github.com:adobecom/milo into MWPW-156612

    @npeltier
    npeltier committed Sep 7, 2024
    Configuration menu
    Copy the full SHA
    6c3cb8f View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2024

  1. MWPW-156612 fixing unit tests

    @npeltier
    npeltier committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    5ad2935 View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2024

  1. initial commit

    @Axelcureno
    Axelcureno committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    9aa3eee View commit details
    Browse the repository at this point in the history

  2. Merge branch 'stage' into MWPW-158053

    @Axelcureno
    Axelcureno committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    bc3ae26 View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2024

  1. MWPW-158053: CCD Slide Card

    @Axelcureno
    Axelcureno committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    49b3acd View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2024

  1. RTL alignment

    @Axelcureno
    Axelcureno committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    950c3ae View commit details
    Browse the repository at this point in the history

  2. ccd slice card added to merch-datasource libs

    @Axelcureno
    Axelcureno committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    ed4137a View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2024

  1. review comments addressed

    @Axelcureno
    Axelcureno committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    afaf7ff View commit details
    Browse the repository at this point in the history

  2. so long, milo styles

    @Axelcureno
    Axelcureno committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    95698c4 View commit details
    Browse the repository at this point in the history

  3. decluttered html test page

    @Axelcureno
    Axelcureno committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    ae57a05 View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2024

  1. spectrum ctas in test file

    @Axelcureno
    Axelcureno committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    3a656a7 View commit details
    Browse the repository at this point in the history

  2. removed images and added pixel png

    @Axelcureno
    Axelcureno committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    8273f59 View commit details
    Browse the repository at this point in the history

  3. removed dead code

    @Axelcureno
    Axelcureno committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    cdb6c8c View commit details
    Browse the repository at this point in the history

  4. Update merch-card.ccd-slice.test.html.js

    @Axelcureno
    Axelcureno committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    f30355d View commit details
    Browse the repository at this point in the history

  5. Update merch-twp-d2p.test.html

    @Axelcureno
    Axelcureno committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    f84c67c View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2024

  1. Update ccd-slice.js

    @Axelcureno
    Axelcureno committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    b174f0d View commit details
    Browse the repository at this point in the history

  2. Merge branch 'stage' into MWPW-158053

    @Axelcureno
    Axelcureno committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    3e9ed08 View commit details
    Browse the repository at this point in the history

  3. Update merch-datasource.js

    @Axelcureno
    Axelcureno committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    2b04688 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'stage' into MWPW-158053

    @Axelcureno
    Axelcureno committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    17a18a1 View commit details
    Browse the repository at this point in the history

  5. inherited width of images

    @Axelcureno
    Axelcureno committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    1139b0f View commit details
    Browse the repository at this point in the history

  6. updated deps

    @Axelcureno
    Axelcureno committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    c3289a7 View commit details
    Browse the repository at this point in the history