-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MWPW-152549] BYO SUSI Options to pass in adobeIMS.signIn() #2850
Conversation
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stage #2850 +/- ##
=======================================
Coverage 96.34% 96.34%
=======================================
Files 243 243
Lines 55284 55288 +4
=======================================
+ Hits 53261 53267 +6
+ Misses 2023 2021 -2 ☔ View full report in Codecov by Sentry. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@qiyundai looks pretty good!
I think you might have missed adding this to the jarvis-chat.js though :) . Or was that a deliberate decision?
signInProvider: () => window.adobeIMS?.signIn(getConfig().signInContext),
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good!
This PR has not been updated recently and will be closed in 7 days if no action is taken. Please ensure all checks are passing, https://github.com/orgs/adobecom/discussions/997 provides instructions. If the PR is ready to be merged, please mark it with the "Ready for Stage" label. |
This PR has not been updated recently and will be closed in 7 days if no action is taken. Please ensure all checks are passing, https://github.com/orgs/adobecom/discussions/997 provides instructions. If the PR is ready to be merged, please mark it with the "Ready for Stage" label. |
This PR adds a new attribute in consumer miloConfigs: signInContext
The initial integration is aimed to enabled Milo consumers to pass dctx_id and use custom SUSI context. Currently Events Milo and CC has requests for this feature.
signInContext should be an object. It will be directly injected into all the adobeIMS.signIn() calls so make sure to format them correctly.
There's been some conversation for this in Slack: https://adobedotcom.slack.com/archives/C03HAU5SU2E/p1725483548242449 and a video demo has been provided in the thread.
You may also see the Milo events dev page for testing:
https://milo-susi-options--events-milo--adobecom.hlx.page/events/create-now/promotion-test/san-jose/ca/2024-09-27?timing=1727747999999&milolibs=custom-susi
Clicking the "sign in" button in gnav should take you to the T3 events SUSI experience instead of the federated one. If you don't see the sign in button, you might need to disable CORS.
Resolves: MWPW-152549
Test URLs: