Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MWPW-152549] BYO SUSI Options to pass in adobeIMS.signIn() #2850

Merged
merged 24 commits into from
Oct 21, 2024

Conversation

qiyundai
Copy link
Contributor

@qiyundai qiyundai commented Sep 9, 2024

This PR adds a new attribute in consumer miloConfigs: signInContext
The initial integration is aimed to enabled Milo consumers to pass dctx_id and use custom SUSI context. Currently Events Milo and CC has requests for this feature.

signInContext should be an object. It will be directly injected into all the adobeIMS.signIn() calls so make sure to format them correctly.

There's been some conversation for this in Slack: https://adobedotcom.slack.com/archives/C03HAU5SU2E/p1725483548242449 and a video demo has been provided in the thread.

You may also see the Milo events dev page for testing:
https://milo-susi-options--events-milo--adobecom.hlx.page/events/create-now/promotion-test/san-jose/ca/2024-09-27?timing=1727747999999&milolibs=custom-susi
Clicking the "sign in" button in gnav should take you to the T3 events SUSI experience instead of the federated one. If you don't see the sign in button, you might need to disable CORS.

Resolves: MWPW-152549

Test URLs:

Copy link
Contributor

aem-code-sync bot commented Sep 9, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link

codecov bot commented Sep 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.34%. Comparing base (1bdfd4a) to head (060cf31).
Report is 9 commits behind head on stage.

Additional details and impacted files
@@           Coverage Diff           @@
##            stage    #2850   +/-   ##
=======================================
  Coverage   96.34%   96.34%           
=======================================
  Files         243      243           
  Lines       55284    55288    +4     
=======================================
+ Hits        53261    53267    +6     
+ Misses       2023     2021    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

libs/utils/utils.js Outdated Show resolved Hide resolved
Copy link
Contributor

aem-code-sync bot commented Sep 9, 2024

Page Scores Audits Google
📱 /about/?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /about/?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

test/blocks/ost/mocks/ost-utils.js Outdated Show resolved Hide resolved
libs/blocks/global-navigation/global-navigation.js Outdated Show resolved Hide resolved
libs/utils/utils.js Outdated Show resolved Hide resolved
libs/blocks/ost/ost.js Outdated Show resolved Hide resolved
Copy link
Contributor

@vhargrave vhargrave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@qiyundai looks pretty good!
I think you might have missed adding this to the jarvis-chat.js though :) . Or was that a deliberate decision?
signInProvider: () => window.adobeIMS?.signIn(getConfig().signInContext),

tools/send-to-caas/send-to-caas.js Show resolved Hide resolved
tools/send-to-caas/send-to-caas.js Show resolved Hide resolved
tools/send-to-caas/bulk-publish-to-caas.js Show resolved Hide resolved
libs/utils/utils.js Show resolved Hide resolved
libs/blocks/gnav/gnav.js Show resolved Hide resolved
Copy link
Contributor

@vhargrave vhargrave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

Copy link
Contributor

This PR has not been updated recently and will be closed in 7 days if no action is taken. Please ensure all checks are passing, https://github.com/orgs/adobecom/discussions/997 provides instructions. If the PR is ready to be merged, please mark it with the "Ready for Stage" label.

@github-actions github-actions bot added Stale and removed Stale labels Sep 26, 2024
Copy link
Contributor

github-actions bot commented Oct 5, 2024

This PR has not been updated recently and will be closed in 7 days if no action is taken. Please ensure all checks are passing, https://github.com/orgs/adobecom/discussions/997 provides instructions. If the PR is ready to be merged, please mark it with the "Ready for Stage" label.

@github-actions github-actions bot added the Stale label Oct 5, 2024
@github-actions github-actions bot removed the Stale label Oct 9, 2024
@milo-pr-merge milo-pr-merge bot merged commit e5b7867 into stage Oct 21, 2024
18 checks passed
@milo-pr-merge milo-pr-merge bot deleted the custom-susi branch October 21, 2024 09:19
@mokimo mokimo mentioned this pull request Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready for Stage run-nala Run Nala Test Automation against PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants