MWPW-156749: Fix video CLS #2849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix cls by adding the videoEl without a source * adapt the video hover and in view port play * Remove no-lazy and return earlier * Fix linting issue * Consolidate duplicated logic * Move functions into the init function * Move root margin and use optional chaining * Only query for the videoEl once
mokimo
requested review from
overmyheadandbody,
SilviuLCF,
Dli3 and
robert-bogos
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stage #2849 +/- ##
==========================================
+ Coverage 95.89% 96.25% +0.36%
==========================================
Files 173 238 +65
Lines 46316 54296 +7980
==========================================
+ Hits 44415 52265 +7850
- Misses 1901 2031 +130 ☔ View full report in Codecov by Sentry. |
|
This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR. |
narcis-radu
reviewed
Sep 16, 2024
overmyheadandbody
approved these changes
Sep 16, 2024
narcis-radu
approved these changes
Sep 16, 2024
|
Reminder to set the |
SilviuLCF
approved these changes
Sep 17, 2024
There was a problem hiding this comment.
Verified , testing details https://jira.corp.adobe.com/browse/MWPW-156749
mokimo
added a commit
that referenced
this pull request
Sep 18, 2024
mokimo
added a commit
that referenced
this pull request
Sep 18, 2024
mokimo
added a commit
that referenced
this pull request
Sep 18, 2024
denlight
pushed a commit
that referenced
this pull request
Sep 25, 2024
denlight
pushed a commit
that referenced
this pull request
Sep 25, 2024
denlight
pushed a commit
that referenced
this pull request
Sep 25, 2024
denlight
pushed a commit
that referenced
this pull request
Sep 25, 2024
mokimo
added a commit
that referenced
this pull request
Oct 1, 2024
* Revert "MWPW-156749: Fix video CLS " (#2899) (#2900) Revert "MWPW-156749: Fix video CLS (#2849)" This reverts commit d4134c8. * MWPW-158886: modify the way arbitrary fields are sent to caas from milo * lint * lint again * validated with testing * MWPW-158886: add tests for malformed arbitrary fields * lint * lint * unit tests * actually filling out expected behavior from unit tests --------- Co-authored-by: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com> Co-authored-by: Okan Sahin <[email protected]> Co-authored-by: Blaine Gunn <[email protected]> Co-authored-by: Sheridan Sunier <[email protected]>
overmyheadandbody
pushed a commit
that referenced
this pull request
Oct 11, 2024
* Revert "MWPW-156749: Fix video CLS " (#2899) (#2900) Revert "MWPW-156749: Fix video CLS (#2849)" This reverts commit d4134c8. * Changing z-index of promobar and popup * Changing z-index of promobar and popup * Reverting z-index to 4 for promobar --------- Co-authored-by: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com> Co-authored-by: Okan Sahin <[email protected]> Co-authored-by: Blaine Gunn <[email protected]> Co-authored-by: Akansha Arora <>
overmyheadandbody
pushed a commit
to overmyheadandbody/milo
that referenced
this pull request
Oct 11, 2024
…becom#2991) * Revert "MWPW-156749: Fix video CLS " (adobecom#2899) (adobecom#2900) Revert "MWPW-156749: Fix video CLS (adobecom#2849)" This reverts commit d4134c8. * Changing z-index of promobar and popup * Changing z-index of promobar and popup * Reverting z-index to 4 for promobar --------- Co-authored-by: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com> Co-authored-by: Okan Sahin <[email protected]> Co-authored-by: Blaine Gunn <[email protected]> Co-authored-by: Akansha Arora <>
milo-pr-merge bot
added a commit
that referenced
this pull request
Oct 23, 2024
* Revert "MWPW-156749: Fix video CLS " (#2899) (#2900) Revert "MWPW-156749: Fix video CLS (#2849)" This reverts commit d4134c8. * MWPW-157946: added colon to be consistent with other sort options * MWPW-157946: rearranged sort orders * missed changing the way last modified was displayed * missed changing the way last modified was displayed * missed changing the way last modified was displayed --------- Co-authored-by: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com> Co-authored-by: Okan Sahin <[email protected]> Co-authored-by: Blaine Gunn <[email protected]> Co-authored-by: Sheridan Sunier <[email protected]> Co-authored-by: Sheridan Sunier <[email protected]>
mokimo
added a commit
that referenced
this pull request
Oct 24, 2024
…ub (#3086) * Revert "MWPW-156749: Fix video CLS " (#2899) (#2900) Revert "MWPW-156749: Fix video CLS (#2849)" This reverts commit d4134c8. * [MWPW-159903] Fix quiz video marquees (#3009) (#3013) fix quiz marquees * [MWPW-159328] handle a case where there are not placeholders availabl… (#3014) [MWPW-159328] handle a case where there are not placeholders available (#2998) * [MWPW-159328] handle a case where there are not palceholders availble * fixed typos --------- Co-authored-by: Denys Fedotov <[email protected]> Co-authored-by: Denys Fedotov <[email protected]> * MWPW-146211 [MILO][MEP] Option to select all elements (#2976) (#3023) * stash * stash * stash * working well * set updated command list for inline * remove querySelector function * unit test and custom block fix * updates for in-block * merch-card-collection unit test fixed * unit test updates * more unit test repair * linting errors * more linting * Fix Invalid selector test * add coverage * force git checks to refire * remove comment * pass rootEl to getSelectedElements for use when needed (gnav) * skip if clause in codecov --------- Co-authored-by: Vivian A Goodrich <[email protected]> Co-authored-by: markpadbe <[email protected]> * MWPW-158455: Promobar overlays with localnav elements in devices (#2991) * Revert "MWPW-156749: Fix video CLS " (#2899) (#2900) Revert "MWPW-156749: Fix video CLS (#2849)" This reverts commit d4134c8. * Changing z-index of promobar and popup * Changing z-index of promobar and popup * Reverting z-index to 4 for promobar --------- Co-authored-by: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com> Co-authored-by: Okan Sahin <[email protected]> Co-authored-by: Blaine Gunn <[email protected]> Co-authored-by: Akansha Arora <> * increase workercount and add webkit run --------- Co-authored-by: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com> Co-authored-by: Okan Sahin <[email protected]> Co-authored-by: Blaine Gunn <[email protected]> Co-authored-by: Denys Fedotov <[email protected]> Co-authored-by: Denys Fedotov <[email protected]> Co-authored-by: Rares Munteanu <[email protected]> Co-authored-by: Vivian A Goodrich <[email protected]> Co-authored-by: markpadbe <[email protected]> Co-authored-by: Akansha Arora <[email protected]> Co-authored-by: Santoshkumar Sharanappa Nateekar <[email protected]>
milo-pr-merge bot
added a commit
that referenced
this pull request
Oct 30, 2024
* Revert "MWPW-156749: Fix video CLS " (#2899) (#2900) Revert "MWPW-156749: Fix video CLS (#2849)" This reverts commit d4134c8. * [MWPW-159903] Fix quiz video marquees (#3009) (#3013) fix quiz marquees * [MWPW-159328] handle a case where there are not placeholders availabl… (#3014) [MWPW-159328] handle a case where there are not placeholders available (#2998) * [MWPW-159328] handle a case where there are not palceholders availble * fixed typos --------- Co-authored-by: Denys Fedotov <[email protected]> Co-authored-by: Denys Fedotov <[email protected]> * MWPW-146211 [MILO][MEP] Option to select all elements (#2976) (#3023) * stash * stash * stash * working well * set updated command list for inline * remove querySelector function * unit test and custom block fix * updates for in-block * merch-card-collection unit test fixed * unit test updates * more unit test repair * linting errors * more linting * Fix Invalid selector test * add coverage * force git checks to refire * remove comment * pass rootEl to getSelectedElements for use when needed (gnav) * skip if clause in codecov --------- Co-authored-by: Vivian A Goodrich <[email protected]> Co-authored-by: markpadbe <[email protected]> * MWPW-158455: Promobar overlays with localnav elements in devices (#2991) * Revert "MWPW-156749: Fix video CLS " (#2899) (#2900) Revert "MWPW-156749: Fix video CLS (#2849)" This reverts commit d4134c8. * Changing z-index of promobar and popup * Changing z-index of promobar and popup * Reverting z-index to 4 for promobar --------- Co-authored-by: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com> Co-authored-by: Okan Sahin <[email protected]> Co-authored-by: Blaine Gunn <[email protected]> Co-authored-by: Akansha Arora <> * a11y-bot --------- Co-authored-by: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com> Co-authored-by: Okan Sahin <[email protected]> Co-authored-by: Blaine Gunn <[email protected]> Co-authored-by: Denys Fedotov <[email protected]> Co-authored-by: Denys Fedotov <[email protected]> Co-authored-by: Rares Munteanu <[email protected]> Co-authored-by: Vivian A Goodrich <[email protected]> Co-authored-by: markpadbe <[email protected]> Co-authored-by: Akansha Arora <[email protected]> Co-authored-by: Santoshkumar Sharanappa Nateekar <[email protected]>
milo-pr-merge bot
added a commit
that referenced
this pull request
Nov 4, 2024
* Revert "MWPW-156749: Fix video CLS " (#2899) (#2900) Revert "MWPW-156749: Fix video CLS (#2849)" This reverts commit d4134c8. * [MWPW-159903] Fix quiz video marquees (#3009) (#3013) fix quiz marquees * [MWPW-159328] handle a case where there are not placeholders availabl… (#3014) [MWPW-159328] handle a case where there are not placeholders available (#2998) * [MWPW-159328] handle a case where there are not palceholders availble * fixed typos --------- Co-authored-by: Denys Fedotov <[email protected]> Co-authored-by: Denys Fedotov <[email protected]> * MWPW-146211 [MILO][MEP] Option to select all elements (#2976) (#3023) * stash * stash * stash * working well * set updated command list for inline * remove querySelector function * unit test and custom block fix * updates for in-block * merch-card-collection unit test fixed * unit test updates * more unit test repair * linting errors * more linting * Fix Invalid selector test * add coverage * force git checks to refire * remove comment * pass rootEl to getSelectedElements for use when needed (gnav) * skip if clause in codecov --------- Co-authored-by: Vivian A Goodrich <[email protected]> Co-authored-by: markpadbe <[email protected]> * MWPW-158455: Promobar overlays with localnav elements in devices (#2991) * Revert "MWPW-156749: Fix video CLS " (#2899) (#2900) Revert "MWPW-156749: Fix video CLS (#2849)" This reverts commit d4134c8. * Changing z-index of promobar and popup * Changing z-index of promobar and popup * Reverting z-index to 4 for promobar --------- Co-authored-by: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com> Co-authored-by: Okan Sahin <[email protected]> Co-authored-by: Blaine Gunn <[email protected]> Co-authored-by: Akansha Arora <> * MWPW-160058: Fixes tag matching case logic * Update send-utils.js --------- Co-authored-by: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com> Co-authored-by: Okan Sahin <[email protected]> Co-authored-by: Blaine Gunn <[email protected]> Co-authored-by: Denys Fedotov <[email protected]> Co-authored-by: Denys Fedotov <[email protected]> Co-authored-by: Rares Munteanu <[email protected]> Co-authored-by: Vivian A Goodrich <[email protected]> Co-authored-by: markpadbe <[email protected]> Co-authored-by: Akansha Arora <[email protected]>
milo-pr-merge bot
added a commit
that referenced
this pull request
Nov 4, 2024
* Revert "MWPW-156749: Fix video CLS " (#2899) (#2900) Revert "MWPW-156749: Fix video CLS (#2849)" This reverts commit d4134c8. * [MWPW-159903] Fix quiz video marquees (#3009) (#3013) fix quiz marquees * [MWPW-159328] handle a case where there are not placeholders availabl… (#3014) [MWPW-159328] handle a case where there are not placeholders available (#2998) * [MWPW-159328] handle a case where there are not palceholders availble * fixed typos --------- Co-authored-by: Denys Fedotov <[email protected]> Co-authored-by: Denys Fedotov <[email protected]> * MWPW-146211 [MILO][MEP] Option to select all elements (#2976) (#3023) * stash * stash * stash * working well * set updated command list for inline * remove querySelector function * unit test and custom block fix * updates for in-block * merch-card-collection unit test fixed * unit test updates * more unit test repair * linting errors * more linting * Fix Invalid selector test * add coverage * force git checks to refire * remove comment * pass rootEl to getSelectedElements for use when needed (gnav) * skip if clause in codecov --------- Co-authored-by: Vivian A Goodrich <[email protected]> Co-authored-by: markpadbe <[email protected]> * MWPW-158455: Promobar overlays with localnav elements in devices (#2991) * Revert "MWPW-156749: Fix video CLS " (#2899) (#2900) Revert "MWPW-156749: Fix video CLS (#2849)" This reverts commit d4134c8. * Changing z-index of promobar and popup * Changing z-index of promobar and popup * Reverting z-index to 4 for promobar --------- Co-authored-by: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com> Co-authored-by: Okan Sahin <[email protected]> Co-authored-by: Blaine Gunn <[email protected]> Co-authored-by: Akansha Arora <> * MWPW-159381: Removes body overrides from caas.css --------- Co-authored-by: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com> Co-authored-by: Okan Sahin <[email protected]> Co-authored-by: Blaine Gunn <[email protected]> Co-authored-by: Denys Fedotov <[email protected]> Co-authored-by: Denys Fedotov <[email protected]> Co-authored-by: Rares Munteanu <[email protected]> Co-authored-by: Vivian A Goodrich <[email protected]> Co-authored-by: markpadbe <[email protected]> Co-authored-by: Akansha Arora <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR: #2724
Resolves: MWPW-156749
Test URLs:
Onhover play
Onviewport play
Only desktop (mobile should not load the video for perf reasons)
CLS
Bacom tests